Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[go] respect initialisms or acronyms in names #4900

Closed
wants to merge 8 commits into from

Conversation

tomi77
Copy link
Contributor

@tomi77 tomi77 commented Jan 1, 2020

Resolved #4833

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@auto-labeler
Copy link

auto-labeler bot commented Jan 1, 2020

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@wing328
Copy link
Member

wing328 commented Jan 2, 2020

Thanks for the PR. Please PM me via Slack when you've time.

@tomi77
Copy link
Contributor Author

tomi77 commented Jan 2, 2020

@wing328 Sorry, I don't have Slack. Maybe mail/Hangout? tomasz[dot]rup[at]gmail[dot]com

@wing328
Copy link
Member

wing328 commented Jan 2, 2020

Sure let's do it via Google Hangout tomorrow (Friday). Please ping me (wing328hk@gmail.com) when you're free. My timezone is +0800.

@displague
Copy link

Is Exeptions typo'd before this PR? (missing c)

Does this functionality, changing client APIs, need to be behind a generator user flag?

@yuki2006
Copy link

Any updates?

@wing328
Copy link
Member

wing328 commented Aug 10, 2023

we've added name mapping support to the go generators which should allow users to address issues mentioned in this PR: https://github.com/OpenAPITools/openapi-generator/blob/master/docs/customization.md#name-mapping

please give it a try with the latest master.

@wing328 wing328 closed this Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][Go] respect initialisms or acronyms in names
4 participants