Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[typescript-axios][client] Unnecessary imports occurs when using nested model in allOf #4805

Merged
merged 1 commit into from
Dec 18, 2019

Conversation

tanmen
Copy link
Contributor

@tanmen tanmen commented Dec 16, 2019

fixes #4804

Hello.
When using typescript-axios, a warning occurred in unused import.
I tried to fix it, so please take a look if you like.

Before

import { Box } from './box';
import { BoxInBox } from './box-in-box';
import { Response } from './response';

/**
 * 
 * @export
 * @interface BoxesResponse
 */
export interface BoxesResponse {
    /**
     * 
     * @type {string}
     * @memberof BoxesResponse
     */
    status: BoxesResponseStatusEnum;
    /**
     * 
     * @type {number}
     * @memberof BoxesResponse
     */
    id?: number;
    /**
     * 
     * @type {string}
     * @memberof BoxesResponse
     */
    name?: string;
    /**
     * 
     * @type {BoxInBox}
     * @memberof BoxesResponse
     */
    box?: BoxInBox;
}

/**
    * @export
    * @enum {string}
    */
export enum BoxesResponseStatusEnum {
    Success = 'success',
    Error = 'error'
}

After

import { Box } from './box';
import { Response } from './response';

/**
 * 
 * @export
 * @interface BoxesResponse
 */
export type BoxesResponse = Response & Box;

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @nicokoenig (2018/09) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11)

@auto-labeler
Copy link

auto-labeler bot commented Dec 16, 2019

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

Copy link
Member

@macjohnny macjohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macjohnny macjohnny merged commit 375f24f into OpenAPITools:master Dec 18, 2019
@macjohnny macjohnny added this to the 4.2.3 milestone Dec 18, 2019
@tanmen
Copy link
Contributor Author

tanmen commented Dec 18, 2019

thank you for looking!!

@amakhrov amakhrov mentioned this pull request May 27, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][typescript-axios] Unnecessary imports occurs when using nested model in allOf
2 participants