[BUG][PHP] Parameter property style not fully implemented #4640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 28, 2019
wing328
approved these changes
Nov 29, 2019
wing328
changed the title
|
Thanks! :) Always a pleasure to contribute! :) |
|
FYI. I've filed #4648 to clean up other codegen classes. |
|
@thomasphansen thanks for the PR, which has been included in the v4.2.2 release: https://twitter.com/oas_generator/status/1201432648544972800 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(related to #4042)
(Fixes issue #4641)
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.@jebentier @dkarlovi @mandrean @jfastnacht @ackintosh @ybelenko @renepardon
PR #4042 aims to expose style and explode parameter properties to mustache templates. However, this only fully works inside allParams loops - queryParams only receive the explode property, while style remains empty.
The reason for this is because CodegenParameter.java has not fully implemented the style property: it contains only its declaration as a property, but it doesn't deal with it inside its methods - explode, however, is fully implemented there.
I got into this because I'm dealing with PR #3984, which I need to generate a library. Unfortunately, that code is broken due to always getting an empty style, since it loops queryParams. This last one receives copies of allParams parameters, and since the style property is not being copied, it remains empty.