-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multi-part binary array form parameters for Spring Boot and Spring Cloud templates #4616
Conversation
Multi-part binary array strings as outlined in OpenAPITools#3139 resulted in `MultipartFile` rather than `List<MultipartFile>`. This PR attempts to resolve this by adjusting the templates. Two tests have been added: one for `spring-boot` and one for `spring-cloud`. Resolve OpenAPITools#3139
Fix multipart file name and description
Please note that the runner logs a warning when using the defined |
I think the related changes should also apply to the following file: |
I've run the code generator against the specification file locally to check, and you are right. I've fixed that one as well, and have added test coverage for it. Because the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Merge conflicts resolved via 69cb1ce. All tests passed. |
Multi-part binary array strings as outlined in #3139 resulted in
MultipartFile
rather thanList<MultipartFile>
. This PR attempts to resolve this by adjusting the templates for Spring Boot and Spring Cloud. Changes to these templates include:List
where appropriatedescription
rather than a hard-coded oneRequestPart
name rather than hard-coded oneTwo tests have been added: one for
spring-boot
and one forspring-cloud
.Resolve #3139
PR checklist
./bin/
(or Windows batch scripts under.\bin\windows
) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh
,./bin/openapi3/{LANG}-petstore.sh
if updating the code or mustache templates for a language ({LANG}
) (e.g. php, ruby, python, etc).master
,4.3.x
,5.0.x
. Default:master
.@bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608