-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG][R] Fix documentation in R package #4580
Conversation
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
Thanks for the PR. Please run |
Thanks William @wing328 for all your help here and via email. [Update]: It looks like the CI is having issues with setup Best, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It updates the mustache template and simplifies the linking in the documentation so that it works for "non-primitive" types. R is good at looking for the name of the page and by topic with the provided name so that the correct documentation page is displayed.
There are still some unresolved issues concerning some "list" types that show up as
array[class]
but I didn't touch the code for these primitive types. I've run it for ther-petstore.sh
and another API. The results are pretty satisfactory.Reference issue: See #4428
I must say that there was some resistance from @Ramanth which was quite unhelpful because he did not provide concrete evidence to his claim. See: #4428 (comment)
I have tested the generation with the Jar file since and it is working.
Thanks.
PR checklist
./bin/
(or Windows batch scripts under.\bin\windows
) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh
,./bin/openapi3/{LANG}-petstore.sh
if updating the code or mustache templates for a language ({LANG}
) (e.g. php, ruby, python, etc).master
,4.3.x
,5.0.x
. Default:master
.cc: @Ramanth @saigiridhar21