Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support models with multi-level hierarchy (via roxspring) #4503

Conversation

jimschubert
Copy link
Member

@jimschubert jimschubert commented Nov 16, 2019

Testing CI failures for generated outputs from community contribution in #4454

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

Fixes #4423, #1685, #2928, #3058

…ulti-level-model-hierarchy

* origin/master:
  minor fix to CI failure
  feat(dart-dio): correctly handle Map<String, Object>, List<Object> using JsonObject (OpenAPITools#4401)
  [OCAML] Fixes cloud.drone.io ocaml-test (OpenAPITools#4501)
  [elm] Add support for oneOf (OpenAPITools#4434)
  [BUG] [Java] Client resttemplate and webclient. Form Params are badly added when they are lists  (OpenAPITools#4461)
  fix: prevent ClassCastException when handling options of (issue OpenAPITools#4468) (OpenAPITools#4495)
  Fixes Python client Configuration class so each instance uses its own dicts (OpenAPITools#4485)
* master:
  Fixes issues with Scalaz outputs (OpenAPITools#4508)
  update samples
@cvgaviao
Copy link

cvgaviao commented Dec 7, 2019

@jimschubert, since this PR is clean without error. woulnd't be possible to merge it instead of the original one?

@jimschubert jimschubert changed the title [ignore] Evaluating CI issues for contributor. Support models with multi-level hierarchy (via roxspring) Dec 15, 2019
Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested locally and the result is good.

@wing328 wing328 merged commit 376e419 into OpenAPITools:master Dec 27, 2019
@wing328
Copy link
Member

wing328 commented Dec 27, 2019

cc @OpenAPITools/generator-core-team

@roxspring
Copy link
Contributor

These changes should fix #4423, #1685, #2928, #3058 but since #4454 was closed rather than merged then I suspect they need to be manually updated @wing328.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allOf Inheritance is broken in schema with more than two layers hierarchy
4 participants