Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kotlin-client][kotlin-server] feature: allow creation of kotlin data classes that implement java.io.Serializable #4005

Closed
wants to merge 4 commits into from
Closed

[kotlin-client][kotlin-server] feature: allow creation of kotlin data classes that implement java.io.Serializable #4005

wants to merge 4 commits into from

Conversation

janweinschenker
Copy link
Contributor

…rializable, by adding the config option serializableModel=(true|false)

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language. @jimschubert (2017/09) ❤️, @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04)

Description of the PR

I added a new configOption "serializableModel=(true|false)" to org.openapitools.codegen.languages.AbstractKotlinCodegen and to the files

  • kotlin-server/data_class.mustache
  • kotlin-client/data_class.mustache

in order to allow to generate kotlin data classes that implement the interface "java.io.Serializable". This will come in handy if data classes are generated with the intention to store data in databases or in distributed caches (i.e. hazelcast)

@auto-labeler
Copy link

auto-labeler bot commented Sep 30, 2019

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@wing328
Copy link
Member

wing328 commented Oct 1, 2019

@janweinschenker thanks for the PR. I noticed you've filed #3997 for master.

Once we have merged that, we'll sync the changes to 4.2.x and 5.0.x so I'll close this PR unless you've other good reasons to have it opened.

@wing328 wing328 closed this Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants