-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[swift4] update Alamofire from 4.7.0 to 4.9.0 #3999
[swift4] update Alamofire from 4.7.0 to 4.9.0 #3999
Conversation
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
@4brunu thanks for the PR. The CI failure is not related to this PR. |
Tested locally and the tests passed:
|
I'll run swiftlint in another PR to reformat the code. |
@4brunu thanks for the PR. Given that my local test result is good, let's go with what you've changed so far. |
@4brunu if you plan to submit more PRs for Swift, please install swiftlint locally in your machine. |
@wing328 thanks 👍 |
* [swift4] update Alamofire from 4.7.0 to 4.9.0 * [swift4] update Petstore samples * [swift4] update Alamofire from 4.5.0 to 4.9.0 in Cartfile * [swift4] update Petstore samples
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
,./bin/openapi3/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.master
,4.1.x
,5.0.x
. Default:master
.Description of the PR
According to the last checkbox I think I should tag you, sorry if I'm wrong, first contribution...
@jgavris @ehyche @Edubits @jaz-ah @d-date
This PR fixes #2300 by updating the version of alomofire in podspec and cartfile.