Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[typescript][fetch] Fix null typing errors #3919

Merged
merged 3 commits into from
Sep 20, 2019
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -229,14 +229,14 @@ export class {{classname}} extends runtime.BaseAPI {
{{/returnType}}
}

/**
{{#notes}}
* {{&notes}}
{{/notes}}
{{#summary}}
* {{&summary}}
{{/summary}}
*/
/**
{{#notes}}
* {{&notes}}
{{/notes}}
{{#summary}}
* {{&summary}}
{{/summary}}
*/
{{^useSingleRequestParameter}}
async {{nickname}}({{#allParams}}{{paramName}}{{^required}}?{{/required}}: {{#isEnum}}{{{datatypeWithEnum}}}{{/isEnum}}{{^isEnum}}{{{dataType}}}{{#isNullable}} | null{{/isNullable}}{{/isEnum}}{{#hasMore}}, {{/hasMore}}{{/allParams}}): Promise<{{#returnType}}{{{returnType}}}{{/returnType}}{{^returnType}}void{{/returnType}}> {
{{#returnType}}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ export function {{classname}}FromJSONTyped(json: any, ignoreDiscriminator: boole
{{/hasVars}}
}

export function {{classname}}ToJSON(value?: {{classname}}): any {
export function {{classname}}ToJSON(value?: {{classname}} | null): any {
{{#hasVars}}
if (value === undefined) {
return undefined;
Expand All @@ -116,14 +116,14 @@ export function {{classname}}ToJSON(value?: {{classname}}): any {
{{#vars}}
{{^isReadOnly}}
{{#isPrimitiveType}}
'{{baseName}}': {{#isDate}}{{^required}}value.{{name}} === undefined ? undefined : {{/required}}value.{{name}}.toISOString().substr(0,10){{/isDate}}{{#isDateTime}}{{^required}}value.{{name}} === undefined ? undefined : {{/required}}value.{{name}}.toISOString(){{/isDateTime}}{{^isDate}}{{^isDateTime}}value.{{name}}{{/isDateTime}}{{/isDate}},
'{{baseName}}': {{#isDate}}{{^required}}value.{{name}} == null ? undefined : {{/required}}value.{{name}}.toISOString().substr(0,10){{/isDate}}{{#isDateTime}}{{^required}}value.{{name}} == null ? undefined : {{/required}}value.{{name}}.toISOString(){{/isDateTime}}{{^isDate}}{{^isDateTime}}value.{{name}}{{/isDateTime}}{{/isDate}},
{{/isPrimitiveType}}
{{^isPrimitiveType}}
{{#isListContainer}}
'{{baseName}}': {{^required}}value.{{name}} === undefined ? undefined : {{/required}}(value.{{name}} as Array<any>).map({{#items}}{{datatype}}{{/items}}ToJSON),
'{{baseName}}': {{^required}}value.{{name}} == null ? undefined : {{/required}}(value.{{name}} as Array<any>).map({{#items}}{{datatype}}{{/items}}ToJSON),
{{/isListContainer}}
{{#isMapContainer}}
'{{baseName}}': {{^required}}value.{{name}} === undefined ? undefined : {{/required}}mapValues(value.{{name}}, {{#items}}{{datatype}}{{/items}}ToJSON),
'{{baseName}}': {{^required}}value.{{name}} == null ? undefined : {{/required}}mapValues(value.{{name}}, {{#items}}{{datatype}}{{/items}}ToJSON),
{{/isMapContainer}}
{{^isListContainer}}
{{^isMapContainer}}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,9 @@ export class PetApi extends runtime.BaseAPI {
return new runtime.VoidApiResponse(response);
}

/**
* Add a new pet to the store
*/
/**
* Add a new pet to the store
*/
async addPet(requestParameters: AddPetRequest): Promise<void> {
await this.addPetRaw(requestParameters);
}
Expand Down Expand Up @@ -140,9 +140,9 @@ export class PetApi extends runtime.BaseAPI {
return new runtime.VoidApiResponse(response);
}

/**
* Deletes a pet
*/
/**
* Deletes a pet
*/
async deletePet(requestParameters: DeletePetRequest): Promise<void> {
await this.deletePetRaw(requestParameters);
}
Expand Down Expand Up @@ -183,10 +183,10 @@ export class PetApi extends runtime.BaseAPI {
return new runtime.JSONApiResponse(response, (jsonValue) => jsonValue.map(PetFromJSON));
}

/**
* Multiple status values can be provided with comma separated strings
* Finds Pets by status
*/
/**
* Multiple status values can be provided with comma separated strings
* Finds Pets by status
*/
async findPetsByStatus(requestParameters: FindPetsByStatusRequest): Promise<Array<Pet>> {
const response = await this.findPetsByStatusRaw(requestParameters);
return await response.value();
Expand Down Expand Up @@ -228,10 +228,10 @@ export class PetApi extends runtime.BaseAPI {
return new runtime.JSONApiResponse(response, (jsonValue) => jsonValue.map(PetFromJSON));
}

/**
* Multiple tags can be provided with comma separated strings. Use tag1, tag2, tag3 for testing.
* Finds Pets by tags
*/
/**
* Multiple tags can be provided with comma separated strings. Use tag1, tag2, tag3 for testing.
* Finds Pets by tags
*/
async findPetsByTags(requestParameters: FindPetsByTagsRequest): Promise<Array<Pet>> {
const response = await this.findPetsByTagsRaw(requestParameters);
return await response.value();
Expand Down Expand Up @@ -264,10 +264,10 @@ export class PetApi extends runtime.BaseAPI {
return new runtime.JSONApiResponse(response, (jsonValue) => PetFromJSON(jsonValue));
}

/**
* Returns a single pet
* Find pet by ID
*/
/**
* Returns a single pet
* Find pet by ID
*/
async getPetById(requestParameters: GetPetByIdRequest): Promise<Pet> {
const response = await this.getPetByIdRaw(requestParameters);
return await response.value();
Expand Down Expand Up @@ -307,9 +307,9 @@ export class PetApi extends runtime.BaseAPI {
return new runtime.VoidApiResponse(response);
}

/**
* Update an existing pet
*/
/**
* Update an existing pet
*/
async updatePet(requestParameters: UpdatePetRequest): Promise<void> {
await this.updatePetRaw(requestParameters);
}
Expand Down Expand Up @@ -355,9 +355,9 @@ export class PetApi extends runtime.BaseAPI {
return new runtime.VoidApiResponse(response);
}

/**
* Updates a pet in the store with form data
*/
/**
* Updates a pet in the store with form data
*/
async updatePetWithForm(requestParameters: UpdatePetWithFormRequest): Promise<void> {
await this.updatePetWithFormRaw(requestParameters);
}
Expand Down Expand Up @@ -403,9 +403,9 @@ export class PetApi extends runtime.BaseAPI {
return new runtime.JSONApiResponse(response, (jsonValue) => ModelApiResponseFromJSON(jsonValue));
}

/**
* uploads an image
*/
/**
* uploads an image
*/
async uploadFile(requestParameters: UploadFileRequest): Promise<ModelApiResponse> {
const response = await this.uploadFileRaw(requestParameters);
return await response.value();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,10 @@ export class StoreApi extends runtime.BaseAPI {
return new runtime.VoidApiResponse(response);
}

/**
* For valid response try integer IDs with value < 1000. Anything above 1000 or nonintegers will generate API errors
* Delete purchase order by ID
*/
/**
* For valid response try integer IDs with value < 1000. Anything above 1000 or nonintegers will generate API errors
* Delete purchase order by ID
*/
async deleteOrder(requestParameters: DeleteOrderRequest): Promise<void> {
await this.deleteOrderRaw(requestParameters);
}
Expand Down Expand Up @@ -90,10 +90,10 @@ export class StoreApi extends runtime.BaseAPI {
return new runtime.JSONApiResponse<any>(response);
}

/**
* Returns a map of status codes to quantities
* Returns pet inventories by status
*/
/**
* Returns a map of status codes to quantities
* Returns pet inventories by status
*/
async getInventory(): Promise<{ [key: string]: number; }> {
const response = await this.getInventoryRaw();
return await response.value();
Expand Down Expand Up @@ -122,10 +122,10 @@ export class StoreApi extends runtime.BaseAPI {
return new runtime.JSONApiResponse(response, (jsonValue) => OrderFromJSON(jsonValue));
}

/**
* For valid response try integer IDs with value <= 5 or > 10. Other values will generated exceptions
* Find purchase order by ID
*/
/**
* For valid response try integer IDs with value <= 5 or > 10. Other values will generated exceptions
* Find purchase order by ID
*/
async getOrderById(requestParameters: GetOrderByIdRequest): Promise<Order> {
const response = await this.getOrderByIdRaw(requestParameters);
return await response.value();
Expand Down Expand Up @@ -156,9 +156,9 @@ export class StoreApi extends runtime.BaseAPI {
return new runtime.JSONApiResponse(response, (jsonValue) => OrderFromJSON(jsonValue));
}

/**
* Place an order for a pet
*/
/**
* Place an order for a pet
*/
async placeOrder(requestParameters: PlaceOrderRequest): Promise<Order> {
const response = await this.placeOrderRaw(requestParameters);
return await response.value();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,10 +80,10 @@ export class UserApi extends runtime.BaseAPI {
return new runtime.VoidApiResponse(response);
}

/**
* This can only be done by the logged in user.
* Create user
*/
/**
* This can only be done by the logged in user.
* Create user
*/
async createUser(requestParameters: CreateUserRequest): Promise<void> {
await this.createUserRaw(requestParameters);
}
Expand Down Expand Up @@ -113,9 +113,9 @@ export class UserApi extends runtime.BaseAPI {
return new runtime.VoidApiResponse(response);
}

/**
* Creates list of users with given input array
*/
/**
* Creates list of users with given input array
*/
async createUsersWithArrayInput(requestParameters: CreateUsersWithArrayInputRequest): Promise<void> {
await this.createUsersWithArrayInputRaw(requestParameters);
}
Expand Down Expand Up @@ -145,9 +145,9 @@ export class UserApi extends runtime.BaseAPI {
return new runtime.VoidApiResponse(response);
}

/**
* Creates list of users with given input array
*/
/**
* Creates list of users with given input array
*/
async createUsersWithListInput(requestParameters: CreateUsersWithListInputRequest): Promise<void> {
await this.createUsersWithListInputRaw(requestParameters);
}
Expand Down Expand Up @@ -175,10 +175,10 @@ export class UserApi extends runtime.BaseAPI {
return new runtime.VoidApiResponse(response);
}

/**
* This can only be done by the logged in user.
* Delete user
*/
/**
* This can only be done by the logged in user.
* Delete user
*/
async deleteUser(requestParameters: DeleteUserRequest): Promise<void> {
await this.deleteUserRaw(requestParameters);
}
Expand All @@ -205,9 +205,9 @@ export class UserApi extends runtime.BaseAPI {
return new runtime.JSONApiResponse(response, (jsonValue) => UserFromJSON(jsonValue));
}

/**
* Get user by user name
*/
/**
* Get user by user name
*/
async getUserByName(requestParameters: GetUserByNameRequest): Promise<User> {
const response = await this.getUserByNameRaw(requestParameters);
return await response.value();
Expand Down Expand Up @@ -247,9 +247,9 @@ export class UserApi extends runtime.BaseAPI {
return new runtime.TextApiResponse(response);
}

/**
* Logs user into the system
*/
/**
* Logs user into the system
*/
async loginUser(requestParameters: LoginUserRequest): Promise<string> {
const response = await this.loginUserRaw(requestParameters);
return await response.value();
Expand All @@ -273,9 +273,9 @@ export class UserApi extends runtime.BaseAPI {
return new runtime.VoidApiResponse(response);
}

/**
* Logs out current logged in user session
*/
/**
* Logs out current logged in user session
*/
async logoutUser(): Promise<void> {
await this.logoutUserRaw();
}
Expand Down Expand Up @@ -310,10 +310,10 @@ export class UserApi extends runtime.BaseAPI {
return new runtime.VoidApiResponse(response);
}

/**
* This can only be done by the logged in user.
* Updated user
*/
/**
* This can only be done by the logged in user.
* Updated user
*/
async updateUser(requestParameters: UpdateUserRequest): Promise<void> {
await this.updateUserRaw(requestParameters);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export function CategoryFromJSONTyped(json: any, ignoreDiscriminator: boolean):
};
}

export function CategoryToJSON(value?: Category): any {
export function CategoryToJSON(value?: Category | null): any {
if (value === undefined) {
return undefined;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export function ModelApiResponseFromJSONTyped(json: any, ignoreDiscriminator: bo
};
}

export function ModelApiResponseToJSON(value?: ModelApiResponse): any {
export function ModelApiResponseToJSON(value?: ModelApiResponse | null): any {
if (value === undefined) {
return undefined;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ export function OrderFromJSONTyped(json: any, ignoreDiscriminator: boolean): Ord
};
}

export function OrderToJSON(value?: Order): any {
export function OrderToJSON(value?: Order | null): any {
if (value === undefined) {
return undefined;
}
Expand All @@ -87,7 +87,7 @@ export function OrderToJSON(value?: Order): any {
'id': value.id,
'petId': value.petId,
'quantity': value.quantity,
'shipDate': value.shipDate === undefined ? undefined : value.shipDate.toISOString(),
'shipDate': value.shipDate == null ? undefined : value.shipDate.toISOString(),
'status': value.status,
'complete': value.complete,
};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ export function PetFromJSONTyped(json: any, ignoreDiscriminator: boolean): Pet {
};
}

export function PetToJSON(value?: Pet): any {
export function PetToJSON(value?: Pet | null): any {
if (value === undefined) {
return undefined;
}
Expand All @@ -99,7 +99,7 @@ export function PetToJSON(value?: Pet): any {
'category': CategoryToJSON(value.category),
'name': value.name,
'photoUrls': value.photoUrls,
'tags': value.tags === undefined ? undefined : (value.tags as Array<any>).map(TagToJSON),
'tags': value.tags == null ? undefined : (value.tags as Array<any>).map(TagToJSON),
'status': value.status,
};
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export function TagFromJSONTyped(json: any, ignoreDiscriminator: boolean): Tag {
};
}

export function TagToJSON(value?: Tag): any {
export function TagToJSON(value?: Tag | null): any {
if (value === undefined) {
return undefined;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ export function UserFromJSONTyped(json: any, ignoreDiscriminator: boolean): User
};
}

export function UserToJSON(value?: User): any {
export function UserToJSON(value?: User | null): any {
if (value === undefined) {
return undefined;
}
Expand Down