Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ruby][Client] Add "send" to ruby reserved word list #3146

Merged
merged 1 commit into from
Jun 21, 2019

Conversation

martynav
Copy link
Contributor

@martynav martynav commented Jun 12, 2019

Ruby clients call self.send(:"#{key}=", value). This breaks if a response entity exposes a 'send' attribute.

This change adds ruby's "#send" to the reserved word list for the ruby generator.

@martynav martynav changed the title Add "send" to ruby reserved word list [Ruby][Client] Add "send" to ruby reserved word list Jun 12, 2019
@wing328
Copy link
Member

wing328 commented Jun 21, 2019

cc Ruby Tech committee: @cliffano (2017/07) @zlx (2017/09) @autopp (2019/02)

@autopp
Copy link
Contributor

autopp commented Jun 21, 2019

@martynav I'm sorry that the review will be late. I'll review it.

@wing328 wing328 added this to the 4.0.3 milestone Jun 21, 2019
Copy link
Contributor

@autopp autopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@martynav Thank you for the PR. Looks good 👍

@autopp autopp merged commit f6c738e into OpenAPITools:master Jun 21, 2019
jimschubert added a commit to jimschubert/openapi-generator that referenced this pull request Jun 24, 2019
* master: (25 commits)
  Add #send to ruby reserved word list (OpenAPITools#3146)
  Merge java8 doc for spring (OpenAPITools#3122)
  added api key authentication to aspnetcore 2.1 (OpenAPITools#3089)
  Add "yue9944882" to Perl technical committee (OpenAPITools#3194)
  [csharp-netcore]: Adding http response details in api_docs and making example snippet compilable (OpenAPITools#3128)
  generate travis configuration (OpenAPITools#3193)
  Perl: Basic bearer auth support (OpenAPITools#3192)
  [R] feat(r) : Alternate PR for serialization fixes along with WithHttpInfo method enhancement (OpenAPITools#3099)
  improve release checkout script (OpenAPITools#3184)
  Prepare 4.0.3-SNAPSHOT  (OpenAPITools#3185)
  4.0.2 release (OpenAPITools#3181)
  Fix rubocop obsolescence (OpenAPITools#3175)
  Add Fuse to the company list (OpenAPITools#3164)
  Idiomatic Rust returns for Error conversions (OpenAPITools#2812)
  Add API timeout handling (OpenAPITools#3078)
  Import inner items for map (OpenAPITools#3123)
  update core team in pom.xml (OpenAPITools#3126)
  [gradle] Document consuming via gradle plugin portal (OpenAPITools#3125)
  Bump up babel-cli version to fix security alert (OpenAPITools#3121)
  [C++] [cpprestsdk] Add examples and test for cpprestsdk (OpenAPITools#3109)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants