Improve CONTRIBUTING.md #2699
Merged
Improve CONTRIBUTING.md #2699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Indicate that bin/openapi3 scripts should be executed too. Try to clarify how to run tests: * use in sample a client for which tests exist * explain where to run the command and how to find the artifactId
jimschubert
added a commit
that referenced
this pull request
Apr 25, 2019
* master: (40 commits)
Remove quotation marks around {{paramName}} for header params in api-body.mustache (#2727)
Add FiNC Technologies (#2728)
fix missing parenthesis for http bearer auth (#2723)
Add missing closing parenthesis (#2720)
update perl test with correct body parameter (#2717)
[Java][Spring] Fix template for reactive implementation with `interfaceOnly` parameter (#2437)
Bugfix(Perl): Support nested primitive types in ARRARY or HASH for basic object (#2713)
Remove `-XX:MaxPermSize` (#2712)
Remove setting generateAliasAsModel in rust server generator (#2714)
update rust server samples
Revert "update rust samples"
update rust samples
update samples
[Rust Server] Improve XML support (#2504)
Improve CONTRIBUTING.md (#2699)
[PHP][Lumen] Rename template folder (#2707)
[aspnetcore] Support async tasks and some code cleanups (#2629)
[C++][Pistache] Fixed #2643 (#2653)
update petstore samples (#2697)
[JAVA][Webclient]fix select body for url encoded media type. (#2686)
...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to contribute to python Client (#2626) I found that some steps were missing in the CONTRIBUTING.md file.
In this PR I updated CONTRIBUTING.md with what I discovered.
However there are still some things that should be clarified or improved that are not covered by this PR:
mvn integration-test -rf :PythonPetstoreClientTestsfailed withHTTPConnectionPool(host='localhost', port=80): Max retries exceeded with url: /v2/petso I guess some server needs to be started before but I couldn't figure out how.PR checklist
Not applicable
Description of the PR
Indicate that bin/openapi3 scripts should be executed too.
Try to clarify how to run tests: