Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Use background queue when making calls to allow for concurrency (#1966) #2000

Closed
wants to merge 3 commits into from

Conversation

DavePilks
Copy link

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Proposed fix for [BUG] Calls off multiple threads cannot run concurrently in Swift 4

Default service calls to the background queue for Swift 4

@jgavris @ehyche @Edubits @jaz-ah @d-date

@DavePilks DavePilks changed the title BUGFIX: Use background queue when making calls to allow for concurrency ([#1966](https://github.com/OpenAPITools/openapi-generator/issues/1966)) BUGFIX: Use background queue when making calls to allow for concurrency (#1966) Jan 28, 2019
@wing328 wing328 added this to the 4.0.0 milestone Feb 13, 2019
@wing328 wing328 modified the milestones: 4.0.0, 4.0.1 May 13, 2019
@wing328 wing328 modified the milestones: 4.0.1, 4.0.2 May 31, 2019
@wing328 wing328 modified the milestones: 4.0.2, 4.0.3 Jun 20, 2019
@wing328 wing328 modified the milestones: 4.0.3, 4.1.0 Jul 9, 2019
@wing328 wing328 modified the milestones: 4.1.0, 4.1.1 Aug 9, 2019
@wing328 wing328 modified the milestones: 4.1.1, 4.1.2 Aug 26, 2019
@wing328 wing328 modified the milestones: 4.1.2, 4.1.3 Sep 11, 2019
@wing328 wing328 modified the milestones: 4.1.3, 4.2.0 Oct 4, 2019
@wing328 wing328 removed this from the 4.2.0 milestone Oct 30, 2019
@wing328
Copy link
Member

wing328 commented Nov 26, 2019

@DavePilks we've merged #4591 instead. Please review and let us know if you still prefer your enhancement and we'll reopen this PR. Thanks.

@wing328 wing328 closed this Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants