-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new generator: typescript-rxjs #1884
Conversation
Feature/rxjs * feat: duplicate typescript-fetch, add docs * duplicate fetch codegen to use for rxjs * remove mapping helpers from modesl * introduce rxjs, adjust apis * make middlewares work * fix namespace issue with babel * fix enum generation * fix formatting of enum * remove other readme * feat: duplicate typescript-fetch, add docs * duplicate fetch codegen to use for rxjs * remove mapping helpers from modesl * introduce rxjs, adjust apis * make middlewares work * fix namespace issue with babel * fix enum generation * fix formatting of enum * remove other readme
cc @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @nicokoenig (2018/09) @topce (2018/10) |
see also #802 (comment) |
...-generator/src/main/java/org/openapitools/codegen/languages/TypeScriptRxjsClientCodegen.java
Outdated
Show resolved
Hide resolved
@denyo I suggest you to add an entry to also, it would be good to have a small integration test to avoid regression issues. see e.g. |
@macjohnny thanks for the feedback and hints. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the interface RequestInit
seems to be missing.
modules/openapi-generator/src/main/resources/typescript-rxjs/runtime.mustache
Show resolved
Hide resolved
modules/openapi-generator/src/main/resources/typescript-rxjs/runtime.mustache
Show resolved
Hide resolved
modules/openapi-generator/src/main/resources/typescript-rxjs/runtime.mustache
Outdated
Show resolved
Hide resolved
modules/openapi-generator/src/main/resources/typescript-rxjs/runtime.mustache
Outdated
Show resolved
Hide resolved
modules/openapi-generator/src/main/resources/typescript-rxjs/runtime.mustache
Show resolved
Hide resolved
modules/openapi-generator/src/main/resources/typescript-rxjs/runtime.mustache
Show resolved
Hide resolved
modules/openapi-generator/src/main/resources/typescript-rxjs/runtime.mustache
Outdated
Show resolved
Hide resolved
modules/openapi-generator/src/main/resources/typescript-rxjs/runtime.mustache
Show resolved
Hide resolved
…untime.mustache Co-Authored-By: denyo <hacker.bernd@gmail.com>
…untime.mustache Co-Authored-By: denyo <hacker.bernd@gmail.com>
…untime.mustache Co-Authored-By: denyo <hacker.bernd@gmail.com>
…untime.mustache Co-Authored-By: denyo <hacker.bernd@gmail.com>
…untime.mustache Co-Authored-By: denyo <hacker.bernd@gmail.com>
…untime.mustache Co-Authored-By: denyo <hacker.bernd@gmail.com>
…untime.mustache Co-Authored-By: denyo <hacker.bernd@gmail.com>
…untime.mustache Co-Authored-By: denyo <hacker.bernd@gmail.com>
Thanks for the additions. |
modules/openapi-generator/src/main/resources/typescript-rxjs/apis.mustache
Outdated
Show resolved
Hide resolved
…pis.mustache Co-Authored-By: denyo <hacker.bernd@gmail.com>
You are right, I missed that. So you can revert the change I suggested that adds the interface |
Will do. Also the one with
|
you are right, it is inside a |
…t-rxjs/runtime.mustache" This reverts commit 26f65ca.
@denyo thanks for the PR, which has been merged into master. @macjohnny thanks for reviewing the change. |
* Merged in feature/rxjs (pull request #2) Feature/rxjs * feat: duplicate typescript-fetch, add docs * duplicate fetch codegen to use for rxjs * remove mapping helpers from modesl * introduce rxjs, adjust apis * make middlewares work * fix namespace issue with babel * fix enum generation * fix formatting of enum * remove other readme * feat: duplicate typescript-fetch, add docs * duplicate fetch codegen to use for rxjs * remove mapping helpers from modesl * introduce rxjs, adjust apis * make middlewares work * fix namespace issue with babel * fix enum generation * fix formatting of enum * remove other readme * add bash scripts to generate samples * remove environment import * add rxjs dependency to package.mustache * add genereated samples * add docs * add windows scripts * adjust license info * update "ensure-up-to-date" by typescript-rxjs * Update modules/openapi-generator/src/main/resources/typescript-rxjs/runtime.mustache Co-Authored-By: denyo <hacker.bernd@gmail.com> * Update modules/openapi-generator/src/main/resources/typescript-rxjs/runtime.mustache Co-Authored-By: denyo <hacker.bernd@gmail.com> * Update modules/openapi-generator/src/main/resources/typescript-rxjs/runtime.mustache Co-Authored-By: denyo <hacker.bernd@gmail.com> * Update modules/openapi-generator/src/main/resources/typescript-rxjs/runtime.mustache Co-Authored-By: denyo <hacker.bernd@gmail.com> * Update modules/openapi-generator/src/main/resources/typescript-rxjs/runtime.mustache Co-Authored-By: denyo <hacker.bernd@gmail.com> * Update modules/openapi-generator/src/main/resources/typescript-rxjs/runtime.mustache Co-Authored-By: denyo <hacker.bernd@gmail.com> * Update modules/openapi-generator/src/main/resources/typescript-rxjs/runtime.mustache Co-Authored-By: denyo <hacker.bernd@gmail.com> * Update modules/openapi-generator/src/main/resources/typescript-rxjs/runtime.mustache Co-Authored-By: denyo <hacker.bernd@gmail.com> * Update modules/openapi-generator/src/main/resources/typescript-rxjs/apis.mustache Co-Authored-By: denyo <hacker.bernd@gmail.com> * fix missing return for Observable<void> * use shorthand syntax * improve linting * improve linting * revert previous changes * Revert "Update modules/openapi-generator/src/main/resources/typescript-rxjs/runtime.mustache" This reverts commit 26f65ca. * recreate typescript-rxjs samples
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
and./bin/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
.master
,. Default:3.4.x
,4.0.x
master
.Description of the PR
This PR adds a new generator
typescript-rxjs
which is based ontypescript-fetch
and replaces allfetch
andPromise
related things with rxjsajax
andObservable
s: https://github.com/ReactiveX/rxjs/blob/master/src/internal/observable/dom/AjaxObservable.ts.