Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a problem that points to a folder that doesn't exist #1863

Merged
merged 4 commits into from
Jan 11, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -536,22 +536,22 @@ public String escapeReservedWord(String name) {

@Override
public String apiFileFolder() {
return (outputFolder + "/" + sourceFolder + "/" + apiPackage()).replace('.', File.separatorChar);
return (outputFolder + "/" + sourceFolder + "/" + apiPackage().replace('.', File.separatorChar)).replace('/', File.separatorChar);
}

@Override
public String apiTestFileFolder() {
return (outputFolder + "/" + testFolder + "/" + apiPackage()).replace('.', File.separatorChar);
return (outputFolder + "/" + testFolder + "/" + apiPackage().replace('.', File.separatorChar)).replace('/', File.separatorChar);
}

@Override
public String modelTestFileFolder() {
return (outputFolder + "/" + testFolder + "/" + modelPackage()).replace('.', File.separatorChar);
return (outputFolder + "/" + testFolder + "/" + modelPackage().replace('.', File.separatorChar)).replace('/', File.separatorChar);
}

@Override
public String modelFileFolder() {
return (outputFolder + "/" + sourceFolder + "/" + modelPackage()).replace('.', File.separatorChar);
return (outputFolder + "/" + sourceFolder + "/" + modelPackage().replace('.', File.separatorChar)).replace('/', File.separatorChar);
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@
import org.testng.Assert;
import org.testng.annotations.Test;

import java.io.File;

public class AbstractJavaCodegenTest {

private final AbstractJavaCodegen fakeJavaCodegen = new P_AbstractJavaCodegen();
Expand Down Expand Up @@ -156,6 +158,49 @@ public void toEnumValue(){
Assert.assertEquals(codegen.toEnumValue("3.14", "Float"), "3.14f");
}

@Test
public void apiFileFolder() {
final AbstractJavaCodegen codegen = new P_AbstractJavaCodegen();
codegen.setOutputDir("/User/open.api.tools");
codegen.setSourceFolder("source.folder");
codegen.setApiPackage("org.openapitools.codegen.api");
Assert.assertEquals(codegen.apiFileFolder(), "/User/open.api.tools/source.folder/org/openapitools/codegen/api".replace('/', File.separatorChar));
}

@Test
public void apiTestFileFolder() {
final AbstractJavaCodegen codegen = new P_AbstractJavaCodegen();
codegen.setOutputDir("/User/open.api.tools");
codegen.setTestFolder("test.folder");
codegen.setApiPackage("org.openapitools.codegen.api");
Assert.assertEquals(codegen.apiTestFileFolder(), "/User/open.api.tools/test.folder/org/openapitools/codegen/api".replace('/', File.separatorChar));
}

@Test
public void modelTestFileFolder() {
final AbstractJavaCodegen codegen = new P_AbstractJavaCodegen();
codegen.setOutputDir("/User/open.api.tools");
codegen.setTestFolder("test.folder");
codegen.setModelPackage("org.openapitools.codegen.model");
Assert.assertEquals(codegen.modelTestFileFolder(), "/User/open.api.tools/test.folder/org/openapitools/codegen/model".replace('/', File.separatorChar));
}

@Test
public void modelFileFolder() {
final AbstractJavaCodegen codegen = new P_AbstractJavaCodegen();
codegen.setOutputDir("/User/open.api.tools");
codegen.setSourceFolder("source.folder");
codegen.setModelPackage("org.openapitools.codegen.model");
Assert.assertEquals(codegen.modelFileFolder(), "/User/open.api.tools/source.folder/org/openapitools/codegen/model".replace('/', File.separatorChar));
}

@Test
public void apiDocFileFolder() {
final AbstractJavaCodegen codegen = new P_AbstractJavaCodegen();
codegen.setOutputDir("/User/open.api.tools");
Assert.assertEquals(codegen.apiDocFileFolder(), "/User/open.api.tools/docs/".replace('/', File.separatorChar));
}

private static class P_AbstractJavaCodegen extends AbstractJavaCodegen {
@Override
public CodegenType getTag() {
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,83 @@
/*
* OpenAPI Petstore
* This spec is mainly for testing Petstore server and contains fake endpoints, models. Please do not use this for any other purpose. Special characters: \" \\
*
* OpenAPI spec version: 1.0.0
*
*
* NOTE: This class is auto generated by OpenAPI Generator (https://openapi-generator.tech).
* https://openapi-generator.tech
* Do not edit the class manually.
*/


package org.openapitools.client.model;

import com.fasterxml.jackson.annotation.JsonProperty;
import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonValue;
import io.swagger.annotations.ApiModel;
import io.swagger.annotations.ApiModelProperty;
import java.math.BigDecimal;
import java.util.ArrayList;
import java.util.List;
import org.junit.Assert;
import org.junit.Ignore;
import org.junit.Test;


/**
* Model tests for TypeHolderDefault
*/
public class TypeHolderDefaultTest {
private final TypeHolderDefault model = new TypeHolderDefault();

/**
* Model tests for TypeHolderDefault
*/
@Test
public void testTypeHolderDefault() {
// TODO: test TypeHolderDefault
}

/**
* Test the property 'stringItem'
*/
@Test
public void stringItemTest() {
// TODO: test stringItem
}

/**
* Test the property 'numberItem'
*/
@Test
public void numberItemTest() {
// TODO: test numberItem
}

/**
* Test the property 'integerItem'
*/
@Test
public void integerItemTest() {
// TODO: test integerItem
}

/**
* Test the property 'boolItem'
*/
@Test
public void boolItemTest() {
// TODO: test boolItem
}

/**
* Test the property 'arrayItem'
*/
@Test
public void arrayItemTest() {
// TODO: test arrayItem
}

}
Original file line number Diff line number Diff line change
@@ -0,0 +1,83 @@
/*
* OpenAPI Petstore
* This spec is mainly for testing Petstore server and contains fake endpoints, models. Please do not use this for any other purpose. Special characters: \" \\
*
* OpenAPI spec version: 1.0.0
*
*
* NOTE: This class is auto generated by OpenAPI Generator (https://openapi-generator.tech).
* https://openapi-generator.tech
* Do not edit the class manually.
*/


package org.openapitools.client.model;

import com.fasterxml.jackson.annotation.JsonProperty;
import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonValue;
import io.swagger.annotations.ApiModel;
import io.swagger.annotations.ApiModelProperty;
import java.math.BigDecimal;
import java.util.ArrayList;
import java.util.List;
import org.junit.Assert;
import org.junit.Ignore;
import org.junit.Test;


/**
* Model tests for TypeHolderExample
*/
public class TypeHolderExampleTest {
private final TypeHolderExample model = new TypeHolderExample();

/**
* Model tests for TypeHolderExample
*/
@Test
public void testTypeHolderExample() {
// TODO: test TypeHolderExample
}

/**
* Test the property 'stringItem'
*/
@Test
public void stringItemTest() {
// TODO: test stringItem
}

/**
* Test the property 'numberItem'
*/
@Test
public void numberItemTest() {
// TODO: test numberItem
}

/**
* Test the property 'integerItem'
*/
@Test
public void integerItemTest() {
// TODO: test integerItem
}

/**
* Test the property 'boolItem'
*/
@Test
public void boolItemTest() {
// TODO: test boolItem
}

/**
* Test the property 'arrayItem'
*/
@Test
public void arrayItemTest() {
// TODO: test arrayItem
}

}
Original file line number Diff line number Diff line change
@@ -0,0 +1,83 @@
/*
* OpenAPI Petstore
* This spec is mainly for testing Petstore server and contains fake endpoints, models. Please do not use this for any other purpose. Special characters: \" \\
*
* OpenAPI spec version: 1.0.0
*
*
* NOTE: This class is auto generated by OpenAPI Generator (https://openapi-generator.tech).
* https://openapi-generator.tech
* Do not edit the class manually.
*/


package org.openapitools.client.model;

import com.fasterxml.jackson.annotation.JsonProperty;
import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonValue;
import io.swagger.annotations.ApiModel;
import io.swagger.annotations.ApiModelProperty;
import java.math.BigDecimal;
import java.util.ArrayList;
import java.util.List;
import org.junit.Assert;
import org.junit.Ignore;
import org.junit.Test;


/**
* Model tests for TypeHolderDefault
*/
public class TypeHolderDefaultTest {
private final TypeHolderDefault model = new TypeHolderDefault();

/**
* Model tests for TypeHolderDefault
*/
@Test
public void testTypeHolderDefault() {
// TODO: test TypeHolderDefault
}

/**
* Test the property 'stringItem'
*/
@Test
public void stringItemTest() {
// TODO: test stringItem
}

/**
* Test the property 'numberItem'
*/
@Test
public void numberItemTest() {
// TODO: test numberItem
}

/**
* Test the property 'integerItem'
*/
@Test
public void integerItemTest() {
// TODO: test integerItem
}

/**
* Test the property 'boolItem'
*/
@Test
public void boolItemTest() {
// TODO: test boolItem
}

/**
* Test the property 'arrayItem'
*/
@Test
public void arrayItemTest() {
// TODO: test arrayItem
}

}
Loading