Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dart-dio] Incorrect hashCode and == overide for fields withList #18198

Conversation

vasilich6107
Copy link
Contributor

@vasilich6107 vasilich6107 commented Mar 21, 2024

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@vasilich6107
Copy link
Contributor Author

vasilich6107 commented Mar 21, 2024

Hi @kuhnroyal
I will fix the test and add the docs later today.

Just pinging you to have an overview of the fix

@wing328
Copy link
Member

wing328 commented Mar 26, 2024

cc
@jaumard (2018/09) @josh-burton (2019/12) @amondnet (2019/12) @sbu-WBT (2020/12) @kuhnroyal (2020/12) @agilob (2020/12) @ahmednfwela (2021/08)

@wing328
Copy link
Member

wing328 commented Mar 26, 2024

please follow step 3 to update the samples and the docs

@vasilich6107
Copy link
Contributor Author

Hi @wing328
Will do all required steps this weekend
Thanks

@vasilich6107 vasilich6107 force-pushed the bugfix/Incorrect-hashCode-and-==-overide-for-fields-withList branch 2 times, most recently from 2f8a517 to 1da43e0 Compare April 25, 2024 11:53
@vasilich6107 vasilich6107 force-pushed the bugfix/Incorrect-hashCode-and-==-overide-for-fields-withList branch from 1da43e0 to 5760d9a Compare April 25, 2024 12:06
@vasilich6107 vasilich6107 force-pushed the bugfix/Incorrect-hashCode-and-==-overide-for-fields-withList branch from 196579e to 63e7f97 Compare April 25, 2024 12:34
@vasilich6107 vasilich6107 force-pushed the bugfix/Incorrect-hashCode-and-==-overide-for-fields-withList branch from 63e7f97 to 6de1da7 Compare April 25, 2024 13:00
@vasilich6107
Copy link
Contributor Author

vasilich6107 commented Apr 25, 2024

Hi @wing328 @kuhnroyal @ahmednfwela
I finished the PR
Sorry for delay

Copy link
Contributor

@kuhnroyal kuhnroyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, you could mention in the doc/help that this only works for freezed.

@vasilich6107
Copy link
Contributor Author

Hi @kuhnroyal
This is not for freezed.
it just uses different approach for equality check calculations based on utils functions from equatable library

@kuhnroyal
Copy link
Contributor

Right, sorry. I meant to say for json_serializable - as this option does nothing when you select built_value as serialization library.

@vasilich6107 vasilich6107 force-pushed the bugfix/Incorrect-hashCode-and-==-overide-for-fields-withList branch from f7bf667 to d40a44e Compare April 27, 2024 12:10
Copy link
Contributor

@kuhnroyal kuhnroyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
@wing328 This is ready

@vasilich6107
Copy link
Contributor Author

Hi @wing328
We've finished with the PR. Could you merge it.
Thanks

@vasilich6107
Copy link
Contributor Author

Hi @wing328
This Friday is a nice time to merge this awesome PR! :-)

@wing328 wing328 merged commit 3d15864 into OpenAPITools:master May 19, 2024
15 checks passed
@wing328
Copy link
Member

wing328 commented May 19, 2024

just merged. sorry for the delay

thanks again for the PR

@vasilich6107
Copy link
Contributor Author

No problem.
Thanks a lot for your work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants