-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dart-dio] Incorrect hashCode and == overide for fields withList #18198
[dart-dio] Incorrect hashCode and == overide for fields withList #18198
Conversation
Hi @kuhnroyal Just pinging you to have an overview of the fix |
cc |
modules/openapi-generator/src/test/java/org/openapitools/codegen/AbstractOptionsTest.java
Outdated
Show resolved
Hide resolved
please follow step 3 to update the samples and the docs |
Hi @wing328 |
2f8a517
to
1da43e0
Compare
1da43e0
to
5760d9a
Compare
…-==-overide-for-fields-withList
196579e
to
63e7f97
Compare
63e7f97
to
6de1da7
Compare
Hi @wing328 @kuhnroyal @ahmednfwela |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, you could mention in the doc/help that this only works for freezed.
Hi @kuhnroyal |
Right, sorry. I meant to say for |
f7bf667
to
d40a44e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
@wing328 This is ready
Hi @wing328 |
Hi @wing328 |
just merged. sorry for the delay thanks again for the PR |
No problem. |
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)