Cherrypick 1391 : address comment nits #1489
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bring my fork up to date with base
Catch up to mothership
I think these tests cover all the problems with rust-server and inline objects I know about. This should show us when we've fixed the problem. Also fixes a CI failure.
* Avoid creating unused ThreadPools Instead, create ApiClient.pool on first request for .pool property. avoids spawning n-cpus threads (the default for ThreadPool) at instantiation of every ApiClient * update doc * set pool_thread to None
* add post processing to kotlin file * restore kotlin samples
* Re-instate ApiRequestParser It turns out I was over-eager when removing file support and accidentally deleted some code that should have been kept. See https://github.com/OpenAPITools/openapi-generator/pull/547/files#diff-684007b298ee5998fa30732c261ea2fcL469. * Don't do html escaping of parameters
* add file post processing to php * restore php petstore client
…OpenAPITools#1357) code if the yml-definition does not have any type definitions. This is normal if the api only uses simple datatypes (Int, String) for inout/output.
* Add parcelizeModels cli option * Add info log to clarify the parcelization requirements. * Update docs
* Fix warnings produced when using Swift 4.2 * Update Petstore client for Swift 4
* remove duplicated imports * fix model import in java * update generator docs * fix model import for retrofit2 client
…ls#1415) Add tip about running online openapi-generator via Docker
* add top level x-group-parameters support * update petstore samples
* Fix return_type parameter examples * $ bin/openapi3/ruby-client-petstore.sh
* test run-in-docker in travis * fix command path * correct batch mode arg * disable useSystemClassLoader
Run entrypoint script
…napi-generator into cherrypick-1391 # Conflicts: # modules/openapi-generator/src/main/java/org/openapitools/codegen/DefaultGenerator.java
|
Too many stray diffs showed up, need help |
This was referenced Jul 31, 2022
This was referenced Jul 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,3.4.x,4.0.x. Default:master.Description of the PR
Address comment nits for 1391