Remove wrong request mapping for feign clients

[MelleD]

PR checklist

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package 
  ./bin/generate-samples.sh
  ./bin/utils/export_docs_generators.sh
  

  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

[welshm]

Looks good to me!

[welshm]

Ah I guess this didn't exist, it just relied on importing the correct apiClient.mustache instead

[MelleD]

Yes correct

[welshm]

@MelleD do you think this is good to merge? The Feing issue is gaining more traction, would be nice to get a fix in the next patch release 🙏

[MelleD]

@MelleD do you think this is good to merge? The Feing issue is gaining more traction, would be nice to get a fix in the next patch release 🙏

Yes for me it’s finish and mergeable

[welshm]

@wing328 I think this is good to go, probably fixes some of the Feign issues

[cachescrubber]

@MelleD I just stumbled upon the @RequestMapping issue. IIRC especially when using the spring-cloud feign client, one should not annotate the interface with the @RequestMapping annotation. See spring-cloud/spring-cloud-netflix#466. But the useFeignClient option as in this PR would activate the annotation, right?

[cachescrubber]

Sorry @MelleD, the logic behind useFeignClient seems right.

I still have breaking builds where interfaceOnly is used. There is currently no way to disable the @RequestMapping Annotation in this scenario. Hmm. Would't it be better to opt-in for @RequestMapping in the interface?

[gorefest]

@cachescrubber with 6.2.1 a regression has been brought into the spring generator. It now - again - places @NotNull validations even with useBeanValidation=false and - worse - it forgets to add the import into the generated interface