Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Typescript-node] fix handling of --model-name-prefix|suffix options, second attempt #11966

Merged

Conversation

ty-v1
Copy link
Contributor

@ty-v1 ty-v1 commented Mar 25, 2022

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Description of the PR

I added TypeScriptNodeClientCodegen#removeModelPrefixSuffix to remove prefix/suffix defined by --model-name-prefix|suffix options and unit tests.

After merging #11956, the arg type of TypescriptNodeClientCodegen#postProcessAllModels had changed, so I fixed unit tests.

Related issue and PRs

#2590
#11956
#2560

Todo

  • run mvn -e --no-snapshot-updates --quiet --batch-mode --show-version clean install -Dorg.slf4j.simpleLogger.defaultLogLevel=error in local

@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03)

@ty-v1 ty-v1 marked this pull request as draft March 25, 2022 05:39
@ty-v1 ty-v1 changed the title [WIP][Typescript-node] fix handling of --model-name-prefix|suffix options, second attempt [Typescript-node] fix handling of --model-name-prefix|suffix options, second attempt Mar 25, 2022
@ty-v1 ty-v1 marked this pull request as ready for review March 25, 2022 05:57
Copy link
Member

@macjohnny macjohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macjohnny macjohnny merged commit 5fa08b9 into OpenAPITools:master Mar 25, 2022
@macjohnny macjohnny added this to the 6.0.0 milestone Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants