Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[typescript-fetch] fix circular imports being generated #10798

Merged
merged 1 commit into from
Nov 22, 2021

Conversation

BeryJu
Copy link
Contributor

@BeryJu BeryJu commented Nov 6, 2021

templates based off of #6140 and @ajaska

closes #6140

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07)
(I didn't want to mention all people at once so I just took the first three)

@BeryJu BeryJu force-pushed the typescript-fetch-fix-circular branch from 50ed417 to 532ed8d Compare November 6, 2021 14:14
@amakhrov
Copy link
Contributor

amakhrov commented Nov 6, 2021

I didn't want to mention all people at once so I just took the first three

you never know who's still active though :). so it's usually more reliable to copy-paste the full list.
the rest:
@kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02)

Copy link
Contributor

@amakhrov amakhrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix - looks good to me.

There seems to be smth off with CI - the failure doesn't look related to the changes in the PR

@BeryJu BeryJu force-pushed the typescript-fetch-fix-circular branch from 532ed8d to c418bb2 Compare November 15, 2021 19:03
Copy link

@torkleyy torkleyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the issue for me as well 👍

@macjohnny macjohnny merged commit 49e9911 into OpenAPITools:master Nov 22, 2021
@macjohnny macjohnny added this to the 5.3.1 milestone Nov 22, 2021
@BeryJu BeryJu deleted the typescript-fetch-fix-circular branch November 22, 2021 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [typescript-fetch] Circular import generated
6 participants