-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[go-server] Feat: add required assertions to models #10068
Conversation
Hi @antihax @grokify @kemokemo @jirikuncar @ph4r5h4d, please help to take a look at this PR |
Tests failure unrelated |
modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/GoServerCodegen.java
Outdated
Show resolved
Hide resolved
I think I might be able to add assertions for Nested arrays (array-in-array). Edit: Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and didn't spot any issue.
* master: (849 commits) Don't use encodeCollectionQueryParameter on maps (OpenAPITools#10116) Fixed the utc time issue for httpSigning auth. (OpenAPITools#10139) [dart][dio] Update built_value to =>8.1.0 (OpenAPITools#10122) Add Inquisico to list of generator users (OpenAPITools#10142) add my companies to README (OpenAPITools#10146) [C][Client] Allocate memory for the element of array when the type is number (OpenAPITools#10124) update samples Fixed typo in csharp-netcore httpclient generated code (OpenAPITools#10119) Typescript-angular: Added missing semi colon to interface export in `apis.ts` template file. (OpenAPITools#10121) Fix issue 10020: [BUG] [typescript-angular] Add "header" to reserved words (OpenAPITools#10091) Add missing samples for OpenAPITools#9857 [typescript] FIX: Generate documentation and examples OpenAPITools#9413 (OpenAPITools#9857) Feat adds has discriminator with non empty mapping (OpenAPITools#9667) Add switches (authentication collections) to support files (OpenAPITools#9884) [dart-dio-next] improve encodeCollectionQueryParameter to handle cases where collectionFormat is null (OpenAPITools#10105) [go-server] Feat: add required assertions to models (OpenAPITools#10068) [dart2] Include request body on DELETE call (OpenAPITools#10100) Make php's array a primitive (OpenAPITools#10093) Fix typo (preffer -> prefer) (OpenAPITools#10098) Fix typo on rust client (OpenAPITools#10096) ...
This PR adds required assertions for models.
This PR does not do assertion checks for:
Feel free to give suggestions, feedback!
Fixes:
A pointer of pointer?
I removed the pointer from the first line.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
,5.3.x
,6.0.x