Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHP] Incorrect return types if multiple responses are defined #125

Closed
fMads opened this issue May 22, 2018 · 1 comment
Closed

[PHP] Incorrect return types if multiple responses are defined #125

fMads opened this issue May 22, 2018 · 1 comment
Labels
Client: PHP

Comments

@fMads
Copy link
Contributor

fMads commented May 22, 2018

Description

If you define multiple responses, the codegen will only support the first one (typically 200).

openapi-generator version

3.0.0-SNAPSHOT

OpenAPI declaration file content or url
  /path
    post:
      responses:
        200:
          schema:
            $ref: '#/definitions/EmptyResponse'
        202:
          schema:
            $ref: '#/definitions/InBackgroundResponse'
Suggest a fix/enhancement

Correctly generate the return-object based on the HTTP Status Code in the Response.
Also fix ReturnType info in DocBlock
@fMads fMads mentioned this issue May 22, 2018
Merged
4 tasks
fMads added a commit to spysystem/openapi-generator that referenced this issue May 22, 2018
@fMads
OpenAPITools#125: Correctly handle multiple valid responses
155970f
fMads added a commit to spysystem/openapi-generator that referenced this issue Jun 7, 2018
@fMads
OpenAPITools#125: Correctly handle multiple valid responses
9dd8008
@thomasphansen thomasphansen mentioned this issue Jun 19, 2018
Closed
ackintosh pushed a commit that referenced this issue Jun 20, 2018
@fMads @ackintosh
[php] Correctly handle multiple valid responses (#128)
d19a2fa 
* #125: Correctly handle multiple valid responses

* Fixed defaultResponses

* Fixed void-returns

* Fixed multiple return-types without an actual type

* Update the samples under openapi3 folder
@ackintosh
Copy link
Contributor

@fMads #128 is merged! Thanks for your contribution.

@scott-lin scott-lin mentioned this issue Nov 27, 2018
Open
@ksvirkou-hubspot ksvirkou-hubspot mentioned this issue Sep 15, 2020
Closed
@uyermolkin-hubspot uyermolkin-hubspot mentioned this issue Oct 14, 2020
Open
@jhogervorst jhogervorst mentioned this issue May 27, 2024
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Client: PHP
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jimschubert @fMads @ackintosh