-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openamp: add new API rpmsg_virtio_get_rx_buffer_size() #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CV-Bowen
force-pushed
the
rx-buff-size-api
branch
from
October 17, 2023 02:22
2accc8b
to
4879af7
Compare
Just rebase to origin/main to pass CI. |
arnopo
requested changes
Oct 19, 2023
CV-Bowen
force-pushed
the
rx-buff-size-api
branch
from
October 20, 2023 07:08
4879af7
to
ba296be
Compare
arnopo
reviewed
Oct 24, 2023
CV-Bowen
force-pushed
the
rx-buff-size-api
branch
from
October 26, 2023 08:40
ba296be
to
a7a13ac
Compare
This API can be used by the endpoint callback to limit the rx buffer usage range. Signed-off-by: Guiding Li <liguiding1@xiaomi.com> Signed-off-by: Bowen Wang <wangbowen6@xiaomi.com>
CV-Bowen
force-pushed
the
rx-buff-size-api
branch
from
October 26, 2023 08:42
a7a13ac
to
9c88fce
Compare
arnopo
approved these changes
Oct 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tnmysh
approved these changes
Nov 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this API, user can get the rx buffer size, and use this buffer safer in endpoint callback function.
Follow shows an example: