openamp: should kick remote when use release_rx_buffer #415
Conversation
|
-- lpcxpresso54114_m4 compile as Master in this sample The following configuration files were considered but not accepted: Call Stack (most recent call first): -- Configuring incomplete, errors occurred! maybe, that's not my fault ? |
Yes, Something seems broken for Zephyr CI, I need to investigate |
Zephyr now needs the 0.15 SDK to be compiled. |
|
CI should be fixed with #417, could you rebase to rerun CI test please |
That's was the issue, thanks for the advice! |
There is missing virtqueue_kick when use hold_rx/release_rx Signed-off-by: Guiding Li <liguiding1@xiaomi.com>
|
@arnopo @carlocaione @edgarigl @jjmcdn |
| @@ -315,6 +315,8 @@ static void rpmsg_virtio_release_rx_buffer(struct rpmsg_device *rdev, | |||
| /* Return buffer on virtqueue. */ | |||
| len = virtqueue_get_buffer_length(rvdev->rvq, idx); | |||
| rpmsg_virtio_return_buffer(rvdev, rp_hdr, len, idx); | |||
| /* tell peer we return some rx buffer */ | |||
There was a problem hiding this comment.
@GUIDINGLI
Please, could you fix typo before I merge?
s/ tell peer we return some rx buffer / Tell peer we return some rx buffers/
|
@GUIDINGLI : I fixed the typo to avoid to integrate it in the coming release commit reference is now: 2b6a38a |
openamp: should kick remote when use release_rx_buffer
There is missing virtqueue_kick when use hold_rx/release_rx
Signed-off-by: Guiding Li liguiding1@xiaomi.com