Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpmsg: merge rpmsg_initialize_ept into rpmsg_register_endpoint #331

Merged
merged 1 commit into from
Jan 25, 2022
Merged

rpmsg: merge rpmsg_initialize_ept into rpmsg_register_endpoint #331

merged 1 commit into from
Jan 25, 2022

Conversation

xiaoxiang781216
Copy link
Collaborator

@xiaoxiang781216 xiaoxiang781216 commented Jan 8, 2022 •
edited
Loading

so the service with preserved address could call rpmsg_register_endpoint only

@xiaoxiang781216
Copy link
Collaborator Author

Since rpmsg_init_ept is deprecated now, it's good time to move it into the internal header file.

arnopo
arnopo requested changes Jan 10, 2022
View reviewed changes
lib/rpmsg/rpmsg.c Outdated Show resolved Hide resolved
lib/rpmsg/rpmsg_internal.h Outdated Show resolved Hide resolved
@xiaoxiang781216 xiaoxiang781216 force-pushed the rpmsg-init-ept branch 2 times, most recently from 3503ffc to 6b8c824 Compare January 10, 2022 13:01
@arnopo arnopo requested a review from edmooring January 10, 2022 15:15
arnopo
arnopo reviewed Jan 10, 2022
View reviewed changes
lib/rpmsg/rpmsg.c Outdated Show resolved Hide resolved
@arnopo arnopo added this to the Release V2022.10 milestone Jan 13, 2022
arnopo
arnopo approved these changes Jan 13, 2022
View reviewed changes
Copy link
Collaborator

@arnopo arnopo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arnopo
Copy link
Collaborator

arnopo commented Jan 13, 2022

Hi @xiaoxiang781216
API policy in project governance specifies that an API must remain in a deprecated state for 2 year (4 releases). So this Pull request (after @edmooring review) will only be integrated for the release 2022.10.

@xiaoxiang781216
rpmsg: merge rpmsg_initialize_ept into rpmsg_register_endpoint
c47d1ca 
so the service with preserved address could call rpmsg_register_endpoint only

Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@xiaoxiang781216 xiaoxiang781216 changed the title rpmsg: move the rpmsg_init_ept to lib/rpmsg/rpmsg_internal.h rpmsg: merge rpmsg_initialize_ept into rpmsg_register_endpoint Jan 13, 2022
@xiaoxiang781216
Copy link
Collaborator Author

xiaoxiang781216 commented Jan 13, 2022 •
edited
Loading

Hi @xiaoxiang781216 API policy in project governance specifies that an API must remain in a deprecated state for 2 year (4 releases). So this Pull request (after @edmooring review) will only be integrated for the release 2022.10.

Ok, the remove split to another patch: #332, so we can merge this patch first.

@arnopo arnopo self-requested a review January 17, 2022 15:19
edmooring
edmooring approved these changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@edmooring edmooring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go.

@arnopo arnopo merged commit b8cd61b into OpenAMP:main Jan 25, 2022
@xiaoxiang781216 xiaoxiang781216 deleted the rpmsg-init-ept branch January 25, 2022 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnopo arnopo arnopo approved these changes

@edmooring edmooring edmooring approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release V2022.04
Development

Successfully merging this pull request may close these issues.
3 participants
@xiaoxiang781216 @arnopo @edmooring