umu_run: handle Protons without an explicit runtime requirement #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle Proton versions that do not set a runtime in their `toolmanifest.vdf`. Such versions include non-runtime versions such as proton-cachyos and Proton from Valve before version 5.13. For now they are executed on the host system outside of the runtime.
Instead of having `check_env` handle the proton download internally, return the download requirement to the caller and handle it there. Simplifies the code in `set_env` by doing a single check to see if umu needs a runtime in this instance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle Proton versions that do not set a runtime in their
toolmanifest.vdf. Such versions include non-runtime versions such as proton-cachyos and Proton from Valve before version 5.13.For now they are executed on the host system outside of the runtime.
Supersedes #401