refactor: don't raise runtime error on failure getting gh assets #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
R1kaB3rN
changed the title
R1kaB3rN
force-pushed
the
proton-runtime-error
branch
from
ee1b1b9 to
4a445f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we were raising a runtime error when we failed to get releases. This wasn't a problem as we pin to a specific Github API version, thus guaranteeing stability of the JSON interface. However, if we ever changed file names to something different (e.g., UMU-Proton9-10.tar.zst), the launcher would crash. In those cases, instead of raising a runtime error, continue to search for Proton in the user's system.