Fixes #2761 change transport direction #2818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yuri05
reviewed
Oct 24, 2023
| if (!sameStructureVersion) | ||
| return false; | ||
|
|
||
| //For individual, there is a special handling required as we need to also check that the used expression profile have hte same structure version |
Yuri05
reviewed
Oct 24, 2023
| if (!sameStructureVersion) | ||
| return false; | ||
|
|
||
| //For individual, there is a special handling required as we need to also check that the used expression profile have hte same structure version |
There was a problem hiding this comment.
Do we need a special handling for populations as well?
There was a problem hiding this comment.
nope. We dont allow commit or update for population
Yuri05
reviewed
Oct 24, 2023
Comment on lines
160
to
163
| //let's compare the expression profile in each individuals and see if they are comparable | ||
| //not the same length of expression profile, structural change | ||
| if (usedIndividual.AllExpressionProfiles().Count != individualTemplate.AllExpressionProfiles().Count) | ||
| return false; |
There was a problem hiding this comment.
Is it actually possible, that sameStructureVersion in the code above is true, but we have a different number of expression profiles??
There was a problem hiding this comment.
I don't think so. you are right this check can be removed.
|
If we use a PR template, we should also tick some options when creating a PR 😉 |
|
Agreed. I forgot to check. Still have to get used to doing this here |
msevestre
deleted the
2761-changing-transpor-direction-in-the-expression-is-not-applied-in-the-simulation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2761
Description
Probem was that it was seen as a non structural change (e.g. changing the expression profile structure). now I am also checking that all used expression profile have the same structure version
Type of change
Please mark relevant options with an
xin the brackets.How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Reviewer checklist
Mark everything that needs to be checked before merging the PR.
This change requires a documentation updateabove is selectedScreenshots (if appropriate):
Questions (if appropriate):