Fixes #2424 output mapping serialization #2425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msevestre
commented
Nov 11, 2022
| @@ -291,7 +291,7 @@ public static SensitivityParameter SensitivityParameter(string name = "Sensitivi | |||
|
|
|||
| public static DataRepository IndividualSimulationDataRepositoryFor(string simulationName) | |||
| { | |||
| var simulationResults = new DataRepository("Results"); | |||
| var simulationResults = new DataRepository(); | |||
There was a problem hiding this comment.
Id was fixed here. Letting the code create the id automatically
| { | ||
| return SetParameterValue(parameter, value); | ||
| } | ||
|
|
||
| public ICommand UpdateParameterValueOrigin(IParameter parameter, ValueOrigin valueOrigin, ISimulation simulation) | ||
| public ICommand UpdateParameterValueOrigin(IParameter parameter, ValueOrigin valueOrigin, IModelCoreSimulation simulation) |
There was a problem hiding this comment.
change related to the change of interface
| @@ -114,6 +114,7 @@ private void exportSimulationToFile(Simulation simulation, string moBiFile) | |||
| var simulationTransfer = new SimulationTransfer | |||
| { | |||
| Simulation = moBiSimulation, | |||
| OutputMappings = simulation.OutputMappings, | |||
There was a problem hiding this comment.
saving the actual output mapping when exporting
| @@ -27,7 +27,7 @@ public SimulationTransfer Load(string pkmlFileFullPath) | |||
| { | |||
| var project = _projectRetriever.CurrentProject; | |||
|
|
|||
| //use new ObjectBaseRepository here as the resulting simulation will be registered later on when added to the project | |||
| //use new WithIdRepository here as the resulting simulation will be registered later on when added to the project | |||
| var simulationTransfer = _simulationPersister.Load(pkmlFileFullPath, new WithIdRepository()); | |||
There was a problem hiding this comment.
Interestingly, we do not load obs data when loading from MoBi (this is not really a use case that is done often). So I am not going to tackle this for now
rwmcintosh
approved these changes
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.