Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2331 Rename tabs for pk analysis on population simulations #2337

Merged
merged 4 commits into from
Sep 15, 2022
Merged

Fixes #2331 Rename tabs for pk analysis on population simulations #2337

merged 4 commits into from
Sep 15, 2022

Conversation

rwmcintosh
Copy link
Member

Easing into the swing of things

@rwmcintosh rwmcintosh marked this pull request as ready for review September 14, 2022 17:20
@msevestre
Copy link
Member

since you have done more than renaming the caption but changing the variables (which I think make sense), there is some left

private readonly IPKAnalysisPivotView _populationAnalysisPivotViewOnCurve;

Copy link
Member

@msevestre msevestre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also rename the pivotView defined in the view

@msevestre msevestre merged commit ce00160 into Open-Systems-Pharmacology:develop Sep 15, 2022
@rwmcintosh rwmcintosh deleted the 2331-rename-tabs branch September 15, 2022 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants