return null if subject not implementing IWithId #2094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msevestre
requested changes
Feb 10, 2022
| @@ -67,7 +67,7 @@ private WorkspaceLayout createNewWorkspaceLayoutWithOpenPresenters() | |||
| var workspaceLayout = new WorkspaceLayout(); | |||
| foreach (var presenter in _applicationController.OpenedPresenters()) | |||
| { | |||
| var withId = presenter.Subject.DowncastTo<IWithId>(); | |||
| var withId = presenter.Subject as IWithId; | |||
| if (withId == null) continue; | |||
msevestre
reviewed
Feb 10, 2022
| } | ||
|
|
||
| [Observation] | ||
| public void should_return_an_object_containing_one_layout_item_for_each_opened_presenter_and_one_for_the_existing_layout_item() |
There was a problem hiding this comment.
Test is ok but this caption is misleading. It does not create a layout item for each opened presenter! You are testing the opposite
msevestre
requested changes
Feb 10, 2022
msevestre
approved these changes
Feb 10, 2022
msevestre
deleted the
2050_Saving_project_with_parameter_identification_feedback_does_not_crash
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2050 (Saving project with parameter identification feedback does not crash)