Fixes #2081 PKSim CLI filter simulation #2082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msevestre
commented
Feb 1, 2022
| @@ -906,6 +906,9 @@ public static string MapToSnapshotNotSupportedWithoutContext(string snapshotType | |||
|
|
|||
| public static string CannotFindSimulationInSnapshot(string simulationName, string project) => CannotFindBuildingBlockInSnapshot(ObjectTypes.Simulation, simulationName, project); | |||
|
|
|||
| public static string SimulationUsedInPlotsAreNotExported(IReadOnlyList<string> simulationNames, string project) | |||
There was a problem hiding this comment.
Making sure that simulation used in plots are also referenced here. This is just a simple validation step.
msevestre
commented
Feb 1, 2022
| /// <summary> | ||
| /// Specifies if project files (snapshot and project should be exported) | ||
| /// </summary> | ||
| public bool ExportProjectFiles { get; set; } |
There was a problem hiding this comment.
Should we export the project files or not. Default will be not because I don't think we need to export those for the qualification
There was a problem hiding this comment.
ok, let's keep it like this.
If this option can be passed to the QualificationRunner later I'm perfectly fine with that :)
Yuri05
approved these changes
Feb 1, 2022
msevestre
commented
Feb 1, 2022
| public IReadOnlyList<string> ReadOnlyMetaDataCategories => new List<string> { }; | ||
| public IReadOnlyList<string> ReadOnlyMetaDataCategories { get; } = new List<string> { }; | ||
|
|
||
| public bool MolWeightAlwaysEditable { get; } = false; |
There was a problem hiding this comment.
@georgeDaskalakis I changed this stuff here. Also when you always return a constant, use {get;} instead 0f => false. A bit faster...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.