Fixes #1939 template db auto update #2043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msevestre
commented
Jan 12, 2022
| public static readonly string PRODUCT_NAME_WITH_TRADEMARK = "PK-Sim®"; | ||
| public static readonly string DEFAULT_SKIN = "Office 2013 Light Gray"; | ||
| public static readonly string VALUE_PROPERTY_NAME = "Value"; | ||
| public static readonly string PROJECT_UNDEFINED = "Undefined"; | ||
| public static readonly string VERSION_FILE_URL = "https://raw.githubusercontent.com/Open-Systems-Pharmacology/Suite/master/versions.json"; | ||
| public static readonly string REMOTE_TEMPLATE_FILE_URL = "https://raw.githubusercontent.com/Open-Systems-Pharmacology/OSPSuite.BuildingBlockTemplates/main/templates.json"; |
There was a problem hiding this comment.
This is the path of the latest file released. When we release a new file, we need to remember to also update the version file in the suite that will be the trigger for the update
There was a problem hiding this comment.
we should setup the develop branch as default in the templates repo then, to make sure that only released versions are merged into main.
There was a problem hiding this comment.
Yep. Can you create an issue for this in the repo?
msevestre
commented
Jan 12, 2022
| using (var wc = new WebClient()) | ||
| { | ||
| var jsonContent = await wc.DownloadStringTaskAsync(VersionFileUrl); | ||
| _allVersions = await _jsonSerializer.DeserializeAsArrayFromString<VersionInfo>(jsonContent); |
There was a problem hiding this comment.
Saving all possible software version available (and not only the one for PKSim). This service is in fact independent from PKSim and could be moved to core
Yuri05
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.