Cat cattle 2 #1960
Merged
Cat cattle 2 #1960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yuri05
commented
Nov 16, 2021
| @@ -67,7 +67,7 @@ INSERT INTO tab_species VALUES('Mouse','Mouse','Mouse',7,0,'Mouse',0); | |||
| INSERT INTO tab_species VALUES('Rabbit','Rabbit','Rabbit',10,0,'Rabbit',0); | |||
| INSERT INTO tab_species VALUES('Rat','Rat','Rat',6,0,'Rat',0); | |||
| INSERT INTO tab_species VALUES('Cat','Cat','Cat',11,0,'Cat',0); | |||
| INSERT INTO tab_species VALUES('Cattle','Cattle','Cattle',12,0,'Cattle',0); | |||
| INSERT INTO tab_species VALUES('Cattle','Cattle (IV only)','Cattle',12,0,'Cattle',0); | |||
There was a problem hiding this comment.
Changed the display name, so that it's immediately clear that we cannot use cattle with oral applications
Yuri05
commented
Nov 16, 2021
| @@ -4482,7 +4521,7 @@ INSERT INTO tab_calculation_method_rates VALUES('VascularEndoVolume','VOLUME_Vas | |||
| INSERT INTO tab_calculation_method_rates VALUES('VascularEndoVolume','VOLUME_VascularEndo_tes','SA_pls_int*d_endo','Volume'); | |||
| INSERT INTO tab_calculation_method_rates VALUES('VascularEndoVolume','VOLUME_VascularEndo_uil','SA_pls_int*d_endo','Volume'); | |||
| INSERT INTO tab_calculation_method_rates VALUES('VascularEndoVolume','VOLUME_VascularEndo_uje','SA_pls_int*d_endo','Volume'); | |||
| INSERT INTO tab_calculation_method_rates VALUES('Lumen_PKSim','PARAM_EffectiveLumenConcentration','EnableSupersaturarion ? M/Liquid : min(Solubility/MW ; M/Liquid)','Concentration (molar)'); | |||
| INSERT INTO tab_calculation_method_rates VALUES('Lumen_PKSim','PARAM_EffectiveLumenConcentration','Liquid>0 ? (EnableSupersaturarion ? M/Liquid : min(Solubility/MW ; M/Liquid)) : 0','Concentration (molar)'); | |||
There was a problem hiding this comment.
Changed the formula so that it does not return NaN if Liquid is zero.
Otherwise it crashed with cattle, because the Gi-TRact is de-facto disabled there (all volumes are set to 0), and our new parameter generation in core did not create this parameter in the simulation at all, because it was NaN
Yuri05
commented
Nov 16, 2021
| if (catParameter.ValueOrigin.Description != "Copied from Beagle") | ||
| continue; | ||
|
|
||
| catParameter.Value.ShouldBeEqualTo(allConstBeagleParameter[i].Value, 1e-5); |
There was a problem hiding this comment.
Checking that if value origin says "Copied from Beagle", then the value is also the same as in beagle :)
Same for Cattle<=>Minipig comparison
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1957 Add physiology data for the species Cattle (IV)
Fixes #293 Add physiology data for the species Cat