Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1912 initial conc variable pop #1937

Merged
merged 4 commits into from
Nov 3, 2021

Conversation

msevestre
Copy link
Member

No description provided.

@msevestre msevestre requested a review from Yuri05 November 2, 2021 20:33
@@ -12442,7 +12442,7 @@ INSERT INTO tab_container_parameters VALUES(5941,'GENERAL','TRANSPORTER','Relati
INSERT INTO tab_container_parameters VALUES(5941,'GENERAL','TRANSPORTER','Start amount',1,1,0,0,'RELATIVE_EXPRESSIONS',1,'LOCAL','SIMULATION',0);
INSERT INTO tab_container_parameters VALUES(5941,'GENERAL','TRANSPORTER','t1/2 (intestine)',1,0,1,1,'RELATIVE_EXPRESSIONS',1,'GLOBAL','INDIVIDUAL',0);
INSERT INTO tab_container_parameters VALUES(5941,'GENERAL','TRANSPORTER','t1/2 (liver)',1,0,1,1,'RELATIVE_EXPRESSIONS',1,'GLOBAL','INDIVIDUAL',0);
INSERT INTO tab_container_parameters VALUES(5941,'GENERAL','TRANSPORTER','Initial concentration',1,0,1,1,'RELATIVE_EXPRESSIONS',1,'LOCAL','INDIVIDUAL',0);
INSERT INTO tab_container_parameters VALUES(5941,'GENERAL','TRANSPORTER','Initial concentration',1,0,1,0,'RELATIVE_EXPRESSIONS',1,'LOCAL','INDIVIDUAL',0);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yuri05 Just realized that this info is in fact not read for the individual (but only when creating the simulation). We have a duplicate in code. Maybe something to improve in the future

@@ -97,7 +97,7 @@ public abstract class IndividualMoleculeFactory<TMolecule, TMoleculeExpressionCo
CalculationMethod = CoreConstants.CalculationMethod.EXPRESSION_PARAMETERS,
BuildingBlockType = PKSimBuildingBlockType.Individual,
CanBeVaried = true,
CanBeVariedInPopulation = true,
CanBeVariedInPopulation = false,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the one

@msevestre msevestre force-pushed the 1912-initial-conc-variable-pop branch from c4d43bb to 859043b Compare November 3, 2021 13:55
@msevestre msevestre merged commit a48f32e into develop Nov 3, 2021
@msevestre msevestre deleted the 1912-initial-conc-variable-pop branch November 3, 2021 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants