Snapshot/Individual: Dimension problems

[Yuri05]

Steps to reproduce described in #724

Similiar to #722

At least here all imported dimensions are set to Dimensionless :)

[msevestre]

Snapshot do not set dimension. They only update unit. Very weird all that :)

[msevestre]

Something is off in the comparison. Our parameters have exactly the same dimension....

[msevestre]

ok those are FORMULA Dimensions that are not set in PKSim when CREATING an object. Instead they are set to parameter owner when the project is loaded

[msevestre]

All right. Database dimension for formula rate is wrong!!

[msevestre]

When loading from project, we do the following for constant formula

         var value = parameterElement.GetAttribute(Constants.Serialization.Attribute.VALUE).ConvertedTo<double>();
         var formula = serializationContext.ObjectFactory.Create<ConstantFormula>().WithValue(value).WithDimension(parameter.Dimension);
         parameter.Formula = formula;

The constant formula get's the dimension of the parameter. That's why it works

FIX 1:
Actually fix the database. This will also fix #722

FIX 2:
When creating a parameter, always setting formula.dimension to parameter.dimension

My vote would be to make it right and do fix 1. Hence assigned to you

[msevestre]

FYI:
I just created following method in ParameterFactory

  private void synchronizeFormulaDimension(IParameter parameter)
      {
         if (parameter?.Formula == null)
            return;

         parameter.Formula.Dimension = parameter.Dimension;
      }

to ensure that formula dimension are always synchronized with Parameter.
No more difference

[msevestre]

going to submit that as a fix. But feel free to fix it right :)

[msevestre]

Also fixes #722 obviously

A lot of dimensions are wrong in the DB

[msevestre]

luckily this is just for constant parameter that are defined as formula and this is always accurate as soon as a project is saved and loaded