Remove unused observers from the database

[Yuri05]

The observers in the table below, which are part of the PK-Sim database, seems to be unused.

unused observers

observer
Fraction dissolved particles
Fraction dissolved particles1
Fraction dissolved particles10
Fraction dissolved particles11
Fraction dissolved particles12
Fraction dissolved particles13
Fraction dissolved particles14
Fraction dissolved particles15
Fraction dissolved particles16
Fraction dissolved particles17
Fraction dissolved particles18
Fraction dissolved particles19
Fraction dissolved particles2
Fraction dissolved particles20
Fraction dissolved particles3
Fraction dissolved particles4
Fraction dissolved particles5
Fraction dissolved particles6
Fraction dissolved particles7
Fraction dissolved particles8
Fraction dissolved particles9
Fraction insoluble particles
Fraction insoluble particles1
Fraction insoluble particles10
Fraction insoluble particles11
Fraction insoluble particles12
Fraction insoluble particles13
Fraction insoluble particles14
Fraction insoluble particles15
Fraction insoluble particles16
Fraction insoluble particles17
Fraction insoluble particles18
Fraction insoluble particles19
Fraction insoluble particles2
Fraction insoluble particles20
Fraction insoluble particles3
Fraction insoluble particles4
Fraction insoluble particles5
Fraction insoluble particles6
Fraction insoluble particles7
Fraction insoluble particles8
Fraction insoluble particles9
Fraction solid particles
Fraction solid particles1
Fraction solid particles10
Fraction solid particles11
Fraction solid particles12
Fraction solid particles13
Fraction solid particles14
Fraction solid particles15
Fraction solid particles16
Fraction solid particles17
Fraction solid particles18
Fraction solid particles19
Fraction solid particles2
Fraction solid particles20
Fraction solid particles3
Fraction solid particles4
Fraction solid particles5
Fraction solid particles6
Fraction solid particles7
Fraction solid particles8
Fraction solid particles9

There are no entries in tab_model_observes for them; in PK-Sim code we have only one place where the names of those observers are used - but the breakpoints are never hit when creating a simulation with particles dissolution formulation(s).

PK-Sim/src/PKSim.Core/Services/SimulationPersistableUpdater.cs

Lines 119 to 137 in 61c5946

	/// <summary>
	/// Return true if an application observer should not be hidden from user
	/// </summary>
	/// <param name="observer"></param>
	private bool applicationObserverShouldBeShown(IObserver observer)
	{
	string name = observer.Name;
	if (name.StartsWith(CoreConstants.Observer.FRACTION_SOLID_PREFIX))
	return true;
	if (name.StartsWith(CoreConstants.Observer.FRACTION_DISSOLVED_PREFIX))
	return true;
	if (name.StartsWith(CoreConstants.Observer.FRACTION_INSOLUBLE_PREFIX))
	return true;
	return false;
	}

I assume those observers were created in the past somewhere in the code (in ParticleApplicationCreator or so), but were dropped when the implementaion of particles dissolution was improved some years ago.

So I think it is safe to delete them.

@msevestre FYI

[msevestre]

lol if yo usay so...happy to delete