Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explanation for Phenotype? #2059

Closed
msevestre opened this issue Jan 18, 2022 · 12 comments
Closed

Explanation for Phenotype? #2059

msevestre opened this issue Jan 18, 2022 · 12 comments

Comments

@msevestre
Copy link
Member

I am sure people won't understand what's required here.
Should we give an example or add some text explaining ?
image

@StephanSchaller @PavelBal @Yuri05

@Yuri05
Copy link
Member

Yuri05 commented Jan 18, 2022

Metabolizing enzyme is clear I guess, so we would need an explanation only for the phenotype.
By the way: should we prepopulate the Phenotype with some common values as well ("Healthy", "Low metabolizer", whatever)?

P.S. For the protein name (and for the phenotype, in case we would like to add some predefined values): I would include into the explanation that the value can be also entered as free text and not only selected from the list.

@PavelBal
Copy link
Member

I had to think hard to understand what is required here :D

How about just "Profile name"? With a hint "Name of this specific expression profile. You can define multiple expression profiles for the same protein". The different profiles must not represent only different phenotypes, it could also be e.g. profiles from different sources (e.g. one from RT-PCR, one EST, one "manual").

@msevestre
Copy link
Member Author

Ok so we rename phenotype to sthg else? Phenotype was a proposal from @StephanSchaller but I agree that this might be confusing
It's not really the Profle Name.... Since the name is composed of Species, Molecule and "Category"

@Yuri05
Copy link
Member

Yuri05 commented Jan 21, 2022

It's not really the Profle Name

"Description"?
"Category"?
"Categorization"?

@msevestre
Copy link
Member Author

Ok this is becoming urgent as I am drafting the documentation and taking screenshots. How do we name this field?

@PavelBal
Copy link
Member

Category, subtype..

@Yuri05
Copy link
Member

Yuri05 commented Feb 18, 2022

@sfrechen @JanSchlender

@StephanSchaller
Copy link
Member

What is this entry good for. Only as info, or does it have any functional purpose (e.g. as "metabolizing enzyme")?
Call it "Tag" if it is only for info?

@sfrechen
Copy link
Member

Phenotype is a very general description of waht is exactly needed here and would probably have fit the purpose. If that really confusion (why?), then I would prefer Pavel's suggestion "Profile name".

@PavelBal
Copy link
Member

I actually also like "Phenotype", it is the matter of proper tooltip to make sure user knows what to enter. E.g.

"Enter a unique name for the expression of this protein. Multiple expression profiles of the same protein are allowed to describe different phenotypes or disease states".

@msevestre
Copy link
Member Author

Phenotype it is then.

@msevestre
Copy link
Member Author

here we go
image

msevestre added a commit that referenced this issue Feb 23, 2022
msevestre added a commit that referenced this issue Mar 8, 2022
msevestre added a commit that referenced this issue Mar 8, 2022
* Fixes #2059 add explanation phenotype

* Fixes #2059 add explanation phenotype
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants