Generate Id for ParameterIdentificationFeedback object so it can be serialized

[abdelr]

Fixes #1488 (Saving project with parameter identification feedback view => crash)

[msevestre]

This line in PK-Sim should be changes
https://github.com/Open-Systems-Pharmacology/PK-Sim/blob/develop/src/PKSim.Presentation/Services/WorkspaceLayoutUpdater.cs#L70

Instead of creating an Id that will not be registered anywhere. CLosing this PR as this will not work

[abdelr]

This line in PK-Sim should be changes https://github.com/Open-Systems-Pharmacology/PK-Sim/blob/develop/src/PKSim.Presentation/Services/WorkspaceLayoutUpdater.cs#L70

Instead of creating an Id that will not be registered anywhere. CLosing this PR as this will not work

@msevestre Well, it did not crash anymore. The idea of saving the object was inspired by the fact that you mentioned that there is a way to save the project so you could resume it later in the exact state it was when it closed. So, for example, all dialogs that were opened should remain as they were. In such a case, we do need to have the object saved into the project, right?

[msevestre]

For this the object needs to be registered. and available. By creating the ID by hand, it defeats the purpose of registration.

[abdelr]

Ok so, should we register it and make it available or should we ignore it as you propose modifying the WorkspaceLayoutUpater? Also, I was considering some more changes to turn the subject into a IWithId, otherwise the downcast is missing some logic to return null in case it is not implementing the inteface.

[msevestre]

no downacast. Jsut use as if it's null return? or what a I missing?

[abdelr]

Could we talk?

[abdelr]

The code on WorkspaceLayoutUpater already deal with null. The problem is that DowncastTo should do something like:
return objectToCast as T;
So it will return null if the object does not implement T. This is what I mean.

[msevestre]

Yes don't use downcast.
Instead as