-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Open Notebooks page feature #32
base: main
Are you sure you want to change the base?
Add Open Notebooks page feature #32
Conversation
✅ Deploy Preview for oscksa ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Hi @BatoolMM please do review and give feedback, thanks |
Thank you @angemaggy for your wonderful work. A few comments about the PR:
Thank you again for your hard work! |
thanks a lot for your feedback @BatoolMM I am currently working on it. |
Hello @BatoolMM really sorry for the delay, I was sick and wasn't able to work properly. Anyway I am good now. I made all the changes which have been requested by you. Please check and give me a feedback thanks. (I have added the |
@alswajiab @BatoolMM please I need a review for my pr. |
Thank you @angemaggy for applying the changes, this is wonderful but I have these comments:
All contributors will have their names added to the list of contributors after they apply the changes but I am happy to add you now. |
@all-contributors please add @angemaggy for Content |
I've put up a pull request to add @angemaggy! 🎉 |
@BatoolMM I brought the changes, please check it when possible. |
In my current pull request, I worked on
open notebook
and divided into:Summary of the
open notebook
concept.Illustration (image explaining the concept) with alternative tag - you can find any image online!
The video impeded in iframe.
some resource links.
Creation of both the Arabic and English pages.
we could have a look on my work.
En:
Arabic:
For the future work, there is a lot need to be done in the code refactoring.
Many components are reused many times and could conduct to an inconsistency in the code. We could handle the translation more better than creating separate file every time. We could add more languages with less code.
There are some aspects of the page which are not really responsive.
I could also work on UI/UX improvement and the SEO of the website to gain more visibility and friendliness.
I think I could be really good for those tasks.