Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Open Notebooks page feature #32

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

angeangoh
Copy link

@angeangoh angeangoh commented Oct 9, 2022

In my current pull request, I worked on open notebook and divided into:

  • Summary of the open notebook concept.

  • Illustration (image explaining the concept) with alternative tag - you can find any image online!

  • The video impeded in iframe.

  • some resource links.

  • Creation of both the Arabic and English pages.

we could have a look on my work.

En:

1

4

Arabic:

01

03

For the future work, there is a lot need to be done in the code refactoring.

  • Many components are reused many times and could conduct to an inconsistency in the code. We could handle the translation more better than creating separate file every time. We could add more languages with less code.

  • There are some aspects of the page which are not really responsive.

  • I could also work on UI/UX improvement and the SEO of the website to gain more visibility and friendliness.

I think I could be really good for those tasks.

@netlify
Copy link

netlify bot commented Oct 9, 2022

Deploy Preview for oscksa ready!

Name Link
🔨 Latest commit 0c38637
🔍 Latest deploy log https://app.netlify.com/sites/oscksa/deploys/6365056a25a402000ab2da8c
😎 Deploy Preview https://deploy-preview-32--oscksa.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@angeangoh
Copy link
Author

Hi @BatoolMM please do review and give feedback, thanks

@BatoolMM
Copy link
Member

Thank you @angemaggy for your wonderful work. A few comments about the PR:

  • The Arabic alignment needs to be fixed. Arabic is a right-to-left language. Make sure the user can switch between both languages on the same page!
    Screenshot 2022-10-10 at 15 58 58
  • We would like the content to be more concise and organized in bulletin points - similar to this PR Subpage open source #38.
  • Add where the text is cited from.
  • Add where the image is taken from
  • Add a few sentences about the video.

This video is part of Open Life Sciences Programe and the subtitles are available in Arabic and English. The OLS program is for people interested in applying open principles in their work and becoming Open Science ambassadors in their communities.
You may also add a reference for the video:
Please cite: Malvika Sharan, Emmy Tsang, Yo Yehudi, Bérénice Batut, Carlos Martinez, Helena Rasche, Hao Ye, Esther Plomp, Andre Maia Chagas, Georgia Aitkenhead, Suzanne lwai, Otis Smith, Emma Anne Harris, Thomas Mboa, Alex Holinski, Zulidyana Rusnalasari, Nelsy Mtsweni, Rowland Mosbergen, Iratxe Puebla, … Anelda van der Walt. (2021, September 19). Mini Talks/Videos about Open Science from OLS-3 Cohort (v.1.1). Zenodo. https://doi.org/10.5281/zenodo.5515763

  • Since we have multiple PRs on Open Educational resources. Would you like to change the content to address "Open Notebooks" You can use the Turing Way for illustrations and content

Thank you again for your hard work!

@angeangoh
Copy link
Author

Thank you @angemaggy for your wonderful work. A few comments about the PR:

  • The Arabic alignment needs to be fixed. Arabic is a right-to-left language. Make sure the user can switch between both languages on the same page!
    Screenshot 2022-10-10 at 15 58 58
  • We would like the content to be more concise and organized in bulletin points - similar to this PR Subpage open source #38.
  • Add where the text is cited from.
  • Add where the image is taken from
  • Add a few sentences about the video.

This video is part of Open Life Sciences Programe and the subtitles are available in Arabic and English. The OLS program is for people interested in applying open principles in their work and becoming Open Science ambassadors in their communities.
You may also add a reference for the video:
Please cite: Malvika Sharan, Emmy Tsang, Yo Yehudi, Bérénice Batut, Carlos Martinez, Helena Rasche, Hao Ye, Esther Plomp, Andre Maia Chagas, Georgia Aitkenhead, Suzanne lwai, Otis Smith, Emma Anne Harris, Thomas Mboa, Alex Holinski, Zulidyana Rusnalasari, Nelsy Mtsweni, Rowland Mosbergen, Iratxe Puebla, … Anelda van der Walt. (2021, September 19). Mini Talks/Videos about Open Science from OLS-3 Cohort (v.1.1). Zenodo. https://doi.org/10.5281/zenodo.5515763

  • Since we have multiple PRs on Open Educational resources. Would you like to change the content to address "Open Notebooks" You can use the Turing Way for illustrations and content

Thank you again for your hard work!

thanks a lot for your feedback @BatoolMM I am currently working on it.

@angeangoh
Copy link
Author

Hello @BatoolMM really sorry for the delay, I was sick and wasn't able to work properly. Anyway I am good now. I made all the changes which have been requested by you. Please check and give me a feedback thanks. (I have added the open notebooks page) and take in consideration you last review.

@angeangoh angeangoh changed the title Add open education page feature Add Open Notebooks page feature Nov 2, 2022
@angeangoh
Copy link
Author

angeangoh commented Nov 2, 2022

@alswajiab @BatoolMM please I need a review for my pr.
I am also wondering, how to do to be in the readMe contributors section

@BatoolMM
Copy link
Member

BatoolMM commented Nov 3, 2022

Thank you @angemaggy for applying the changes, this is wonderful but I have these comments:

  • The image doesn't provide anything new and it's super large, we need image that simplify the concept of Open Science (with its reference)
  • The links for extra reading shouldn't be listed as URL, every link should have a title.

All contributors will have their names added to the list of contributors after they apply the changes but I am happy to add you now.

@BatoolMM
Copy link
Member

BatoolMM commented Nov 3, 2022

@all-contributors please add @angemaggy for Content

@allcontributors
Copy link
Contributor

@BatoolMM

I've put up a pull request to add @angemaggy! 🎉

@angeangoh
Copy link
Author

@BatoolMM I brought the changes, please check it when possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants