-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs:Added documentation of Keyring Feature #2612
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the description is currently to generic, it should be for a dev looking into this document become faster than looking into the code.
please look into the auth module where it is used and use the default names of the configuration, e.g.
for mscolab it is defined in MSCOLAB_auth_user_name, with "mscolab"
e.g. when auth on the mscolab server is enabled you want to ask. The URL is then the service url.
keyring get MSCOLAB_AUTH_{URL} mscolab
provide the examples based on what we do and need.
look on e.g. our usage of get_password_from_keyring
e.g. https://github.com/Open-MSS/MSS/blob/develop/mslib/msui/mscolab.py#L205
all the descriptions done here can be later also retrieved by perplexity.ai or similiar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just looked at the form of the new docs.
This needs to become a section of development and not on same level.
See for the section codesbuilding-the-docs-with-sphinx
You need to start with a H2
looking on the content next.
@@ -398,6 +398,81 @@ Common resources that a test might need, | |||
like e.g. a running MSColab server or a QApplication instance for GUI tests, | |||
are collected in :mod:`tests.fixtures` in the form of pytest fixtures that can be requested as needed in tests. | |||
|
|||
Testing Keyring Features |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can name it
Keyring Features
testing has some different meaning
|
||
.. code-block:: bash | ||
|
||
keyring set SERVICE_NAME USERNAME |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the examples maybe should destinguish the http_auth protection and a user password.
When you use the keyring set MSCOLAB_AUTH_{url} user@example.com
then it needs a change to keyring set MSCOLAB_AUTH_{url} MSCOLAB_auth_user_name
the default in the configuration is mscolab.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for the WMS Servers this username can differ for each server, an example is given in config.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mscolab has besides the common http_auth also user accounts and they are not described here.
These can become tested when you add a user with a password to your local running server.
Purpose of PR?:
Fixes #2421
Does this PR introduce a breaking change?
No
Does this PR results in some Documentation changes?
Yes
Added relevant documentation updates to Test Keyring Features.
Checklist:
<type>: <subject>