Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fullname Support to User Profiles #2608

Open
wants to merge 19 commits into
base: develop
Choose a base branch
from

Conversation

annapurna-gupta
Copy link
Contributor

Fixes #1282

@ReimarBauer
Copy link
Member

try to alter a test that now also the fullname is checked if one was added

@annapurna-gupta
Copy link
Contributor Author

try to alter a test that now also the fullname is checked if one was added

i am sorry, i didn't understand...can you please explain

@ReimarBauer
Copy link
Member

ReimarBauer commented Jan 26, 2025

image

Where we currenly have Change Avatar, there should be an "Edit"
The Edit should be used to change the Avatar and the Full Name. Changing the e-mail is currently not allowed by user action.

@annapurna-gupta
Copy link
Contributor Author

image

Where we currenly have Change Avatar, there should be an "Edit" The Edit should be used to change the Avatar and the Full Name. Changing the e-mail is currently not allowed by user action.

Screenshot 2025-01-26 172121
Whenever I try to add a user, an error is displayed.

@annapurna-gupta
Copy link
Contributor Author

image

Where we currenly have Change Avatar, there should be an "Edit" The Edit should be used to change the Avatar and the Full Name. Changing the e-mail is currently not allowed by user action.

Is it possible to create a new issue for this change? I would be happy to work on it.

@ReimarBauer
Copy link
Member

image
Where we currenly have Change Avatar, there should be an "Edit" The Edit should be used to change the Avatar and the Full Name. Changing the e-mail is currently not allowed by user action.

Is it possible to create a new issue for this change? I would be happy to work on it.
yes, after the half feature is added, currently someone will ask where is the fullname...

@ReimarBauer
Copy link
Member

try to alter a test that now also the fullname is checked if one was added

i am sorry, i didn't understand...can you please explain

We have now changed the API and the model. The CI runs should cover the changes. The tests are all in your fork too
https://github.com/annapurna-gupta/MSS/tree/feature/add-fullname-nickname/tests

We should have at least a test which covers adding a fullname on user creation
e.g. https://github.com/annapurna-gupta/MSS/blob/feature/add-fullname-nickname/tests/_test_msui/test_mscolab.py#L178

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

user profile options
2 participants