Use find_namespace_packages #2357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes warnings about sub-directories of mslib/ that were previously not part of the packages because they don't contain __init__.py, but that were still recognized and added as packages due to a deprecated behavior of setuptools. The change from exclude to include is due to the excludes not being exhaustive. Multiple consecutive builds would add the entirety of build/ into the package with the excludes. Since we know that mslib and its sub-packages are the only ones that should be distributed we can just be explicit about that.
joernu76
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes warnings about sub-directories of mslib/ that were previously not part of the packages because they don't contain __init__.py, but that were still recognized and added as packages due to a deprecated behavior of setuptools.
The change from exclude to include is due to the excludes not being exhaustive. Multiple consecutive builds would add the entirety of build/ into the package with the excludes. Since we know that mslib and its sub-packages are the only ones that should be distributed we can just be explicit about that.
Purpose of PR?:
Fixes #1643.
Does this PR introduce a breaking change?
If the changes in this PR are manually verified, list down the scenarios covered::
Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Does this PR results in some Documentation changes?
If yes, include the list of Documentation changes
Checklist:
<type>: <subject>