Use isoformat for mscolab timestamps #2345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matrss
requested changes
May 13, 2024
There was a problem hiding this comment.
I think this one needs to be changed as well:
Line 58 in 3ed347b
matrss
reviewed
May 13, 2024
mslib/mscolab/file_manager.py
Outdated
| @@ -399,7 +400,7 @@ def get_all_changes(self, op_id, user, named_version=False): | |||
| 'comment': change.comment, | |||
| 'version_name': change.version_name, | |||
| 'username': change.user.username, | |||
| 'created_at': change.created_at.strftime("%Y-%m-%d, %H:%M:%S.%f %z") | |||
| 'created_at': created_at_isoformat(change.created_at) | |||
There was a problem hiding this comment.
What is wrong with change.created_at.isoformat()?
There was a problem hiding this comment.
seems I looked only on that with the None state.
There was a problem hiding this comment.
on a test: test_get_message_dict
The function strftime returns None when created_at is initialized. But isoformat crashes.
But in that case isoformat gives an AttributeError
and that is because I need to change the test too.
matrss
reviewed
May 14, 2024
matrss
approved these changes
May 14, 2024
matrss
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of PR?:
Fixes #2321
Does this PR introduce a breaking change?
time format change for mscolab