Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove A005 from flake8 checks #2317

Merged
merged 1 commit into from
Apr 11, 2024
Merged

fix: Remove A005 from flake8 checks #2317

merged 1 commit into from
Apr 11, 2024

Conversation

joernu76
Copy link
Member

This test does not provide sensible warnings, currently.

Purpose of PR?:

Fixes #2312

Does this PR introduce a breaking change?

no
If the changes in this PR are manually verified, list down the scenarios covered::

Checklist:

  • Bug fix. Fixes #
  • New feature (Non-API breaking changes that adds functionality)
  • PR Title follows the convention of <type>: <subject>
  • Commit has unit tests

@joernu76 joernu76 requested review from ReimarBauer and matrss April 11, 2024 15:01
@matrss
Copy link
Collaborator

matrss commented Apr 11, 2024

I think this should go to develop, since we don't even have the flake8-builtins checks on stable. If it is really wanted on stable then the change would also need to go into the tool:pytest section of setup.cfg. On develop this duplication is gone already.

@joernu76 joernu76 changed the base branch from stable to develop April 11, 2024 17:13
@joernu76 joernu76 closed this Apr 11, 2024
@joernu76 joernu76 reopened this Apr 11, 2024
@joernu76
Copy link
Member Author

So to develop it goes.

In the flake8 test, I do not see either of the second or third command being output by github. i.e. the pip --upgrade pip command is shown, but neither the installation nor execution of flake8.

I presume flake8 is executed with the "0" as its output?

@matrss
Copy link
Collaborator

matrss commented Apr 11, 2024

In the flake8 test, I do not see either of the second or third command being output by github. i.e. the pip --upgrade pip command is shown, but neither the installation nor execution of flake8.

pip's output from installing flake8 and flake8-builtins is shown (from this line onwards: https://github.com/Open-MSS/MSS/actions/runs/8650673932/job/23719710583?pr=2317#step:4:25).

I presume flake8 is executed with the "0" as its output?

Yes, usually flake8 wouldn't print anything when there is no warning, but due to either the --count or the --statistics option it prints the total number of warnings (which is 0 in this case).

@ReimarBauer ReimarBauer merged commit 6fc2977 into develop Apr 11, 2024
14 of 15 checks passed
@ReimarBauer ReimarBauer deleted the i2312 branch April 11, 2024 19:12
ReimarBauer pushed a commit to ReimarBauer/MSS that referenced this pull request Apr 11, 2024
@joernu76
Copy link
Member Author

In the flake8 test, I do not see either of the second or third command being output by github. i.e. the pip --upgrade pip command is shown, but neither the installation nor execution of flake8.

pip's output from installing flake8 and flake8-builtins is shown (from this line onwards: https://github.com/Open-MSS/MSS/actions/runs/8650673932/job/23719710583?pr=2317#step:4:25).

I presume flake8 is executed with the "0" as its output?

Yes, usually flake8 wouldn't print anything when there is no warning, but due to either the --count or the --statistics option it prints the total number of warnings (which is 0 in this case).

Ah, stupid me hasn't seen the ">" button, which hides all but the first command. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

builtin checker findings for mslib/plugins/io/csv.py and mslib/utils/time.py
3 participants