Remove unnecessary skips #2165
Merged
Remove unnecessary skips #2165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matrss
force-pushed
the
remove-unnecessary-skips
branch
4 times, most recently
from
751980a to
15965c6
Compare
matrss
force-pushed
the
remove-unnecessary-skips
branch
2 times, most recently
from
787c266 to
fb7a4d7
Compare
ReimarBauer
reviewed
Feb 15, 2024
ReimarBauer
reviewed
Feb 15, 2024
matrss
force-pushed
the
remove-unnecessary-skips
branch
from
44ad0e1 to
fea2b51
Compare
matrss
force-pushed
the
remove-unnecessary-skips
branch
from
fea2b51 to
df04a87
Compare
Open
ReimarBauer
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes many unnecessary skips for tests that either work fine or needed just a small amount of changes.
Fixes #2188.
Split off from #2100.
I want to wait with this until after #2158 is merged.