Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update actions used in the workflows #2098

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

matrss
Copy link
Collaborator

@matrss matrss commented Nov 15, 2023

Updates actions/checkout to v4 and actions/setup-python to v4. Some trailing whitespace was removed by my editor as well.

Purpose of PR?:

Fixes #2088

Does this PR introduce a breaking change?

No

Updates actions/checkout to v4 and actions/setup-python to v4.
Some trailing whitespace was removed by my editor as well.
@ReimarBauer
Copy link
Member

@matrss I think that should better go into stable and later merged into develop. I don't know when V4 is required and how long we need until we release 9.0.0.

@matrss
Copy link
Collaborator Author

matrss commented Nov 15, 2023

I am pretty sure that actions/checkout uses standard git commands to fetch the repository and v3 will therefore continue to work for a long time. I don't think we have to worry about this if we will release 9.0.0 in the next 10 years. If it ever does stop working we can still do a backport.

@ReimarBauer ReimarBauer merged commit e8977a0 into Open-MSS:develop Nov 15, 2023
4 checks passed
@matrss matrss deleted the update-checkout-action branch February 16, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use checkout V4 for workflows
2 participants