Properly fix legend issue in develop. #2009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReimarBauer
reviewed
Sep 7, 2023
| @@ -1478,24 +1478,21 @@ def append_multiple_images(self, imgs): | |||
| """ | |||
| images = [x for x in imgs if x] | |||
| if images: | |||
| if hasattr(self.view, 'fig') is False: | |||
There was a problem hiding this comment.
this was needed before not to crash on a different attribute than 'fig'
now it crashes on
Fatal error in MSS 8.3.0 on Linux-6.2.0-10018-tuxedo-x86_64-with-glibc2.35
Python 3.10.8 | packaged by conda-forge | (main, Nov 22 2022, 08:23:14) [GCC 10.4.0]
Please report bugs in MSS to https://github.com/Open-MSS/MSS
Information about the fatal error:
Traceback (most recent call last):
File "/home/reimar/MAIN/MSS/mslib/msui/wms_control.py", line 1383, in continue_retrieve_image
self.display_retrieved_image(img, legend_img, layer, style, init_time, valid_time, complete_level)
File "/home/reimar/MAIN/MSS/mslib/msui/wms_control.py", line 1629, in display_retrieved_image
self.view.draw_legend(self.append_multiple_images(legend_imgs))
File "/home/reimar/MAIN/MSS/mslib/msui/wms_control.py", line 1484, in append_multiple_images
max_height = int((self.view.plotter.fig.get_size_inches() * self.view.plotter.get_dpi())[1] * 0.99)
AttributeError: 'TopViewPlotter' object has no attribute 'get_dpi'
see also
#1803
ReimarBauer
reviewed
Sep 7, 2023
|
Because the actual fix was not properly merged from stable and I botched the manual reapplication. Works now. |
ReimarBauer
reviewed
Sep 7, 2023
| @@ -1412,7 +1412,7 @@ def render_new_permission(self, op_id, u_id): | |||
| operation_desc = f'{operation["path"]} - {operation["access_level"]}' | |||
| widgetItem = QtWidgets.QListWidgetItem(operation_desc, parent=self.ui.listOperationsMSC) | |||
| widgetItem.op_id = operation["op_id"] | |||
| widgetItem.catgegory = operation["category"] | |||
| widgetItem.operation_category = operation["category"] | |||
There was a problem hiding this comment.
here and also in stable I wonder what it means that we don't have seen a failure popping up
There was a problem hiding this comment.
Apparently, you can assign whatever you want as an attribute (yeah, duck-typing!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was fixed in stable. Other improper fixes in develop prevent this from working; also a merge error.
Purpose of PR?:
Fixes #1928