Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logging functionality to socketio added and configured testing for critical erros #1966

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

ReimarBauer
Copy link
Member

Purpose of PR?:

Fixes #1965

Does this PR introduce a breaking change?
needs additional config vars in the server config

If the changes in this PR are manually verified, list down the scenarios covered::

Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Does this PR results in some Documentation changes?
If yes, include the list of Documentation changes

Checklist:

  • Bug fix. Fixes #
  • New feature (Non-API breaking changes that adds functionality)
  • PR Title follows the convention of <type>: <subject>
  • Commit has unit tests

@ReimarBauer ReimarBauer requested a review from joernu76 August 29, 2023 10:41
pytest.ini Outdated
log_format = %(asctime)s %(levelname)s %(message)s
log_date_format = %Y-%m-%d %H:%M:%S
log_cli = 1
log_cli_level = CRITICAL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ERROR?

@ReimarBauer ReimarBauer merged commit 5097eec into develop Sep 1, 2023
@ReimarBauer ReimarBauer deleted the i1965 branch September 1, 2023 13:24
ReimarBauer added a commit that referenced this pull request Sep 6, 2023
…itical erros (#1966)

* logging functionality to socketio added and configured testing for critical errors

* updated to ERROR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

configure easier debugging of socketio servers
2 participants