-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove usage of werkzeug.urls.url_encode #1911
Remove usage of werkzeug.urls.url_encode #1911
Conversation
ebca235
to
b2b82a9
Compare
I don't get why this "AttributeError: module 'PyQt5.QtCore' has no attribute 'Slot'" is happening here, but not on develop. I did not change anything remotely related to that and Both CI runs report the same pyqt version though... |
OK, so it looks like the
in the CI run on develop. I am not sure why that is used in develop but not in this PR pipeline though. Anyway, I think we should change all occurrences of |
b2b82a9
to
828e87f
Compare
That's the difference causing our tests to fail. |
828e87f
to
65c67d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comment.
related to #1614
Good catch ! |
65c67d2
to
f265946
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx
@joernu76 when this is merged we need to patch our server |
Replaces it with
urllib.parse.urlencode
. Fixes #1910.