Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch default cmap of generics to "turbo" and allow reconfiguration … #1821

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Switch default cmap of generics to "turbo" and allow reconfiguration … #1821

merged 1 commit into from
Jul 21, 2023

Conversation

joernu76
Copy link
Member

…in mswms_settings.py

@joernu76 joernu76 requested review from jgrooss and ReimarBauer July 20, 2023 15:50
@ReimarBauer
Copy link
Member

This looks reasonable, please add an issue first, I assume we have also to add a hint to the documentation

@joernu76 joernu76 linked an issue Jul 21, 2023 that may be closed by this pull request
Make default colour map configurable and switch default from "rainbow" to "turbo" #1824
Closed
@joernu76
Copy link
Member Author

issue is linked!

ReimarBauer
ReimarBauer approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@ReimarBauer ReimarBauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@ReimarBauer ReimarBauer merged commit 12a1cbb into develop Jul 21, 2023
@ReimarBauer ReimarBauer deleted the allow_switch_of_cmap_in_generics branch July 21, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReimarBauer ReimarBauer ReimarBauer approved these changes

@jgrooss jgrooss Awaiting requested review from jgrooss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make default colour map configurable and switch default from "rainbow" to "turbo"
2 participants
@joernu76 @ReimarBauer